Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pylint style fixes, pass 1 #139

Merged
merged 8 commits into from
Mar 17, 2023
Merged

Pylint style fixes, pass 1 #139

merged 8 commits into from
Mar 17, 2023

Conversation

yut23
Copy link
Collaborator

@yut23 yut23 commented Mar 16, 2023

This PR is a bunch of minor style fixes suggested by pylint. It resolves all instances of:

  • superfluous-parens
  • no-else-break, no-else-continue, no-else-raise, no-else-return
  • use-symbolic-message-instead
  • trailing-whitespace
  • consider-using-from-import
  • unnecessary-pass (I'm on the fence about this one)
  • attribute-defined-outside-init

@zingale zingale merged commit 4c90ee6 into python-hydro:main Mar 17, 2023
@yut23 yut23 deleted the pylint_fixes branch March 17, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zingale zingale zingale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yut23 @zingale