Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding AWS ECS task definition validation. #512

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adding AWS ECS task definition validation. #512

wants to merge 1 commit into from

Conversation

djgoku
Copy link
Contributor

@djgoku djgoku commented Jan 9, 2025 •
edited
Loading

Since #353 was merged this is now working! Thanks again for adding support in for #353 !

% check-jsonschema --builtin-schema vendor.amazon-ecs-intellisense-schema tests/example-files/hooks/positive/amazon-ecs-intellisense-schema/fargate.json
ok -- validation done

% check-jsonschema --builtin-schema vendor.amazon-ecs-intellisense-schema tests/example-files/hooks/negative/amazon-ecs-intellisense-schema/invalid.json
Schema validation errors were encountered.
  tests/example-files/hooks/negative/amazon-ecs-intellisense-schema/invalid.json::$: 'family' is a required property
  tests/example-files/hooks/negative/amazon-ecs-intellisense-schema/invalid.json::$: 'containerDefinitions' is a required property

@djgoku djgoku force-pushed the feature/add-vendor-aws-ecs-task-definition branch from e2222dc to 0177e56 Compare January 9, 2025 02:34
@djgoku djgoku force-pushed the feature/add-vendor-aws-ecs-task-definition branch from 0177e56 to c81ed4f Compare January 9, 2025 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@djgoku