fix: Python 3.11 date.fromisoformat() allows extra formats #1076
+6
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.11 and later allow additional ISO8601 formats in
datetime
module ISO8601 parsing. These formats are not RFC3339 section 5.6 compliant.Especially
datetime.date.fromisoformat()
now allows strings like:20230328
(2023-03-28)2022W527
(2023-01-01)2023-W01
(2023-01-02)2023-W13-2
(2023-03-28)Fix by doing a regular expression check before passing the value to
datetime
module. This made the original.isascii()
check unnecessary.See:
Tests covering the invalid values to be sent to json-schema-org/JSON-Schema-Test-Suite
Fixes #1056.
📚 Documentation preview 📚: https://python-jsonschema--1076.org.readthedocs.build/en/1076/