Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better unmarshaller finders with refactor #447

Merged
merged 1 commit into from
Dec 21, 2022

Conversation

p1c2u
Copy link
Collaborator

@p1c2u p1c2u commented Dec 17, 2022

Fixes #313 #401

@p1c2u p1c2u force-pushed the refactor/unmarshaller-finders-refactor branch 3 times, most recently from b05e846 to 948c360 Compare December 21, 2022 00:45
@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Merging #447 (b1eaeee) into master (bc78dee) will increase coverage by 0.37%.
The diff coverage is 92.72%.

@@            Coverage Diff             @@
##           master     #447      +/-   ##
==========================================
+ Coverage   92.99%   93.36%   +0.37%     
==========================================
  Files         103      103              
  Lines        2483     2486       +3     
  Branches      220      219       -1     
==========================================
+ Hits         2309     2321      +12     
+ Misses        129      124       -5     
+ Partials       45       41       -4     
Impacted Files Coverage Δ
openapi_core/unmarshalling/schemas/factories.py 97.26% <91.30%> (-2.74%) ⬇️
...penapi_core/unmarshalling/schemas/unmarshallers.py 94.19% <93.02%> (+4.43%) ⬆️
openapi_core/schema/schemas.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@p1c2u p1c2u force-pushed the refactor/unmarshaller-finders-refactor branch 6 times, most recently from 1f8a079 to d28fb26 Compare December 21, 2022 03:07
@p1c2u p1c2u changed the title unmarshaller finders refactor better unmarshaller finders with refactor Dec 21, 2022
@p1c2u p1c2u force-pushed the refactor/unmarshaller-finders-refactor branch from d28fb26 to b1eaeee Compare December 21, 2022 04:07
@p1c2u p1c2u merged commit 612123e into master Dec 21, 2022
@p1c2u p1c2u deleted the refactor/unmarshaller-finders-refactor branch December 21, 2022 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Defaults are not applied when used after an allOf or anyOf
1 participant