Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Requests request dont allow fragments #491

Merged
merged 1 commit into from
Jan 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion openapi_core/contrib/requests/requests.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def __init__(self, request: Union[Request, PreparedRequest]):
self.request = request
if request.url is None:
raise RuntimeError("Request URL is missing")
self._url_parsed = urlparse(request.url)
self._url_parsed = urlparse(request.url, allow_fragments=False)

cookie = {}
if isinstance(self.request, SupportsCookieJar) and isinstance(
Expand Down
27 changes: 27 additions & 0 deletions tests/unit/contrib/requests/test_requests_requests.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,3 +88,30 @@ def test_url_rule(self, request_factory, request):
assert openapi_request.path == "/browse/12/"
assert openapi_request.body == prepared.body
assert openapi_request.mimetype == "application/json"

def test_hash_param(self, request_factory, request):
request = request_factory("GET", "/browse/#12", subdomain="kb")

openapi_request = RequestsOpenAPIRequest(request)

# empty when not bound to spec
path = {}
query = ImmutableMultiDict([])
headers = Headers(
{
"Content-Type": "application/json",
}
)
cookies = {}
assert openapi_request.parameters == RequestParameters(
path=path,
query=query,
header=headers,
cookie=cookies,
)
prepared = request.prepare()
assert openapi_request.method == request.method.lower()
assert openapi_request.host_url == "http://localhost"
assert openapi_request.path == "/browse/#12"
assert openapi_request.body == prepared.body
assert openapi_request.mimetype == "application/json"