Frame position when seeking past the end of file #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
force-pushed
the
eoferror
branch
3 times, most recently
from
7409931 to
3f4a4a2
Compare
radarhere
changed the title
This was referenced Jun 25, 2015
|
This looks like it could use @wiredfool or @hugovk or @homm eyes |
|
looks ok to me. |
aclark4life
added a commit
that referenced
this pull request
Jun 30, 2015
Frame position when seeking past the end of file
|
Thanks @wiredfool and @radarhere and @anntzer |
|
Thanks for that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When some formats seek to a non-existent frame and raise EOFError, tell() then reports the non-existent frame position.
A side effect of this is n_frames reporting an incorrect value.
I've added tests for other formats, except for SPIDER. This is because the test file matches the condition
self.istack == 0on this line which means that seek has no effect.