factory: merge legacy dependencies and groups

[abn]

This change ensures that existence of legacy "dev-dependency" section does not break when "dev" group is added for new dependencies.

root@b447a66339c6:/foobar# cat pyproject.toml 
[tool.poetry]
name = "foobar"
version = "0.1.0"
description = ""
authors = ["Your Name <[email protected]>"]
readme = "README.md"

[tool.poetry.dependencies]
python = "^3.10"

[tool.poetry.group.dev.dependencies]
pycowsay = "^0.0.0.1"

[tool.poetry.dev-dependencies]
pytest = "*"

[build-system]
requires = ["poetry-core"]
build-backend = "poetry.core.masonry.api"
root@b447a66339c6:/foobar# poetry show pycowsay
 name         : pycowsay 
 version      : 0.0.0.1  
 description  :          
root@b447a66339c6:/foobar# poetry show --tree
pytest 7.0.1 pytest: simple powerful testing with Python
├── atomicwrites >=1.0
├── attrs >=19.2.0
├── colorama *
├── iniconfig *
├── packaging *
│   └── pyparsing >=2.0.2,<3.0.5 || >3.0.5 
├── pluggy >=0.12,<2.0
├── py >=1.8.2
└── tomli >=1.0.0
root@b447a66339c6:/foobar# pip uninstall poetry-core
Found existing installation: poetry-core 1.1.0a7
..
  Successfully uninstalled poetry-core-1.1.0a7
root@b447a66339c6:/foobar# pip install -q git+https://github.com/abn/poetry-core.git@groups-merge-dev
root@b447a66339c6:/foobar# poetry show --tree
pycowsay 0.0.0.1
pytest 7.0.1 pytest: simple powerful testing with Python
├── atomicwrites >=1.0
├── attrs >=19.2.0
├── colorama *
├── iniconfig *
├── packaging *
│   └── pyparsing >=2.0.2,<3.0.5 || >3.0.5 
├── pluggy >=0.12,<2.0
├── py >=1.8.2
└── tomli >=1.0.0

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
1.6% Duplication

[andersk]

This commit seems to have broken Poetry’s test_solver_duplicate_dependencies_different_sources_types_are_preserved. If you update poetry-core from Git, that test now raises poetry.puzzle.exceptions.SolverProblemError: Because root depends on both demo (0.1.2 git) and demo (>=0.1.0), version solving failed.

[abn]

This does not relate to the breakage. The tests downstream introduced a case we were previously not testing for. The breakage is related to package similarity check changes.

There already is a fix for this on Poetry.

[andersk]

I believe you that the real bug is elsewhere. But it isn’t fixed as of now. What I’m saying is that

• current poetry master fails with current poetry-core master;
• current poetry master fails with poetry-core where this commit was merged;
• current poetry master succeeds with poetry-core before this commit was merged.

[radoering]

It's kind of related. This PR influences the order of dependencies that are returned by all_requires and thereby reveals a downstream bug in a test added recently in python-poetry/poetry#5640. A fix is on the way: python-poetry/poetry#5654