-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mistyped package name causes infinite loop #3200
Comments
Looks like there is a cyclic dependency involved here.
|
Note that if the dependency is added to pyproject.toml with a dot |
@intgr noticed that. Appreciate the details in your issue report, it is extremely helpful. |
This seems to be the same as #3132. |
Relates-to: python-poetry/poetry#3132 Relates-to: python-poetry/poetry#3200
The issue was in how we normalised the name of the package. This needs a fix in core. And another change in poetry itself. |
Relates-to: python-poetry/poetry#3132 Relates-to: python-poetry/poetry#3200
Wondering whether there has been any progress on this? |
As I understand, commit python-poetry/poetry-core@b0d9086 was supposed to fix this? |
I have tested this out and there still seems to be an issue. I've installed the latest (prerelease) [tool.poetry]
name = "demo"
version = "1"
description = "A Demo"
authors = []
[tool.poetry.dependencies]
python = ">= 3.6"
"ruamel-yaml" = "*" $ poetry lock
Updating dependencies
Resolving dependencies... (138.2s) (I'm not a poetry user, so I might have gone wrong somewhere) |
This was fixed at python-poetry/poetry-core#328 |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
-vvv
option).Issue
I converted my dependencies file using DepHell from Pipfile to requirements.txt to Poetry pyproject.toml. Trying to use this converted file, Poetry for some reason got stuck in an infinite loop. I tracked it down to one bad line.
The PyPI package has a name
ruamel.yaml
(with a dot), but my dependencies had it with a hyphen:ruamel-yaml
Running
poetry lock
on such a file reproduces the infinite loop.This may be partially causing #2094 ("Poetry is extremely slow when resolving the dependencies").
I cannot trigger this issue by using the Poetry command, however. If I write
poetry add ruamel-yaml
, it adds dependency with the correct name"ruamel.yaml" = "^0.16.12"
andpoetry lock
works fine with that.The text was updated successfully, but these errors were encountered: