-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poetry doesn't correctly normalise the package name for the wheel data section #7117
Comments
Please provide the versions you have tested with, as well as examples of the incorrect output, what you expect the correct output to be, and what commands/tools can be used to reproduce. This sounds like a chore, but will get your issue looked at in a more timely fashion and ensure that those who try to help you/reproduce it can do so quickly and consistently. |
sorry, i'm not sure how to do the request for this issue. Do you want me to attach a wheel showing the issue? any poetry built wheel will do... |
A pyproject.toml along with a sequence of commands you are using to build wheels, and then examples of the resulting filenames, plus what you would consider to be the correct filenames, would illustrate your issue and make it unambiguous what is wrong. |
It would probably have been worth mentioning that you've already provided a pull request including unit test changes... |
Thanks David!
…On Wed, 14 Dec 2022 at 09:55, David Hotham ***@***.***> wrote:
It would probably have been worth mentioning that you've already provided
a pull request including unit test changes...
python-poetry/poetry-core#532
<python-poetry/poetry-core#532>
—
Reply to this email directly, view it on GitHub
<#7117 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB4O4EKRSU3TQLZ55K2BYDWNGKQ5ANCNFSM6AAAAAASN2R3ZE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
-vvv
option) and have included the output below.Issue
When building a wheel, the name of the data section should be {distribution}-{version}.data, where {distribution} is the PEP 503 normalisation followed by replacing - with _.
See Binary distribution format
Currently the data section is using _package.name rather than distribution_version(_package.name) (https://github.com/python-poetry/poetry-core/blob/d98aa6e49f614f7631667da3144d7b291c7e7889/src/poetry/core/masonry/builders/wheel.py#L310)
The text was updated successfully, but these errors were encountered: