Fix UnicodeDecodeError caused by opening README with no encoding #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Yeaw <[email protected]>
|
Please read the new reply in #1027 |
drunkwcodes
approved these changes
Apr 11, 2019
|
@sdispater Thanks for poetry |
|
@sdispater Any update on being able to merge this? I have to work around this right now by removing the pyproject.toml when building Gaphor for Windows to force use of a redundant setup.py. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dan Yeaw [email protected]
Pull Request Check List
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!
This PR fixes #1027 by opening the README with the UTF-8 encoding, instead of the default encoding for the platform. I looked at the tests that exist, and the test_builder and test_complete already do quite a bit of testing around importing a description from a README. Would it be worth creating unicode characters in the "complete" README.rst?