Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently "poetry run" command uses subprocess.call for starting
programs and scripts. This approach has a problem --- signals like
Ctrl-C are caught by poetry process itself and not by the process the
user has run.
This can be observed this way: run "poetry run python" and press Ctrl-C.
Normally Python interpreter will catch the signal and print
"KeyboardInterrupt" exception, continuing execution normally. But when
run by poetry, it exits immediately. This behavior is rather annoying,
as one has to restart interpreter after accidentially doing Ctrl-C.
Moreover, after python exits, it leaves terminal in a broken state,
requiring the user to use "reset" or similar command.
This commit fixes this behavior by using "os.execvp" instead of
subprocess. This replaces poetry process directly with target process,
eliminating an intermediate process.
This approach is used in other products like Pipenv and Haskell's build
system stack. See these links for examples and more info:
stack exec
not propagating signals commercialhaskell/stack#527Pull Request Check List
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!
Note: If your Pull Request introduces a new feature or changes the current behavior, it should be based
on the
develop
branch. If it's a bug fix or only a documentation update, it should be based on themaster
branch.If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Notes
run
command in poetry.