[WIP] Add test for pip installing pendulum failing #2262
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abn
reviewed
Apr 14, 2020
| def test_can_install_pendulum_sdist(tmp_venv): | ||
| installer = PipInstaller(tmp_venv, NullIO(), Pool()) | ||
|
|
||
| installer.run("install", "--no-binary", ":all:", "pendulum") |
There was a problem hiding this comment.
This will fail today because poetry-core 1.0.0a5 cannot be installed from source. When pendulum is attempted to be built using PEP-517.
Using pip install --no-binary pendulum should progress further. But will fail when we hit pendulum. Which again attempts to install using setuptools.
This should be resolved once python-poetry/poetry-core#24 is merged.
Julian
added a commit
to Julian/dotfiles
that referenced
this pull request
Jun 7, 2020
Installing it has been broken for a few months -- not sure what the status is or whether there's a desire to fix it (see sdipater/pendulum#454 and python-poetry/poetry#2262) but it's annoying enough that I think it's easier to just axe, given I haven't really gotten enough time to review the two issue tickets.
|
I suspect this is no longer an issue. Closing this for now. Feel free to re-open if this still needs to be added into the codebase. |
Julian
added a commit
to Julian/dotfiles
that referenced
this pull request
Jun 18, 2022
Installing it has been broken for a few months -- not sure what the status is or whether there's a desire to fix it (see sdipater/pendulum#454 and python-poetry/poetry#2262) but it's annoying enough that I think it's easier to just axe, given I haven't really gotten enough time to review the two issue tickets.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python-pendulum/pendulum#458
This PR is most likely going to be deleted but I wanted to provide a reproducible scenario for ... well, the
--no-binarypart is what I did in #458 but the error is what is reported in #454.I will explicitly point out that this would _not_ use the
mastersource of poetry but rather whatever pendulum claims to depend on. Again, this is a publicly running demonstration, not a proposed test or solution. My guess at the solution is to addsetuptoolsas a poetry installation dependency so it will have setuptools when 517 results in poetry installation. Or maybe thebuild-systemrequiresfor pendulum should just get a setuptools. I dunno...