Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installer script and self update command #2535

Closed

Conversation

sdispater
Copy link
Member

The changes made in #2426 (and #1878) can break systems that want to use Python 2 (via python) with a python3 executable available. This is the setup we have in our own CI for Python 2.7.

This PR fixes this by selecting the first executable available. Note that it will still look for python3 is python does not exist.

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

@sdispater sdispater force-pushed the fix-installer-script-and-self-update-command branch from e8761eb to 61a6745 Compare June 10, 2020 15:49
@sdispater sdispater force-pushed the fix-installer-script-and-self-update-command branch from 61a6745 to 355e5c2 Compare June 10, 2020 15:54
@sdispater sdispater closed this Jun 11, 2020
@sdispater sdispater deleted the fix-installer-script-and-self-update-command branch June 11, 2020 08:10
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant