Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc. clean up: Development dependencies, doc build action, tox for doc builds, pre-commit hook updates #2814

Merged
merged 7 commits into from
Aug 20, 2020
Merged

Misc. clean up: Development dependencies, doc build action, tox for doc builds, pre-commit hook updates #2814

merged 7 commits into from
Aug 20, 2020

Conversation

abn
Copy link
Member

@abn abn commented Aug 16, 2020 •
edited
Loading

This changeset includes the following:

  1. Remove mkdoc related dependencies from project dev-dependencies. This makes dependency resolution considerably faster for the poetry package.
  2. Use tox to build doc: tox -e doc.
  3. Add GitHub action to build docs if doc sources change (no publishing, only sanity).
  4. Update isort configuration to v5.
  5. Update all pre-commit hooks.
  6. Use pre-commit as the runner for all code quality checks.

@abn abn requested a review from a team August 16, 2020 00:31
finswimmer
finswimmer approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@finswimmer finswimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@finswimmer finswimmer merged commit d2fd581 into python-poetry:master Aug 20, 2020
@abn abn deleted the cleanup-dev branch August 20, 2020 15:58
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@finswimmer finswimmer finswimmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abn @finswimmer