Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update packaging requirement to support 21.0 #4362

Merged
merged 1 commit into from
Nov 11, 2021
Merged

Update packaging requirement to support 21.0 #4362

merged 1 commit into from
Nov 11, 2021

Conversation

NeilGirdhar
Copy link
Contributor

@NeilGirdhar NeilGirdhar commented Aug 7, 2021 •
edited
Loading

Fixes #4264

@NeilGirdhar
Copy link
Contributor Author

@sdispater Would you mind taking a quick look at this single line change?

@NeilGirdhar
Copy link
Contributor Author

Could even consider ">=" since it looks like packaging isn't going with semantic versioning.

@kkirsche
Copy link
Contributor

Could even consider ">=" since it looks like packaging isn't going with semantic versioning.

https://packaging.pypa.io/en/latest/development/release-process.html seems to confirm this, though I haven't reviewed their Noxfile

@hugovk
Copy link
Contributor

hugovk commented Nov 11, 2021

Could even consider ">=" since it looks like packaging isn't going with semantic versioning.

packaging.pypa.io/en/latest/development/release-process.html seems to confirm this, though I haven't reviewed their Noxfile

Correct, packaging (like pip) follows Calendar Versioning (https://calver.org/): YY.N is the year number and a sequential number.

packaging 21.2 has recently come out: https://pypi.org/project/packaging/#history

hugovk
hugovk previously approved these changes Nov 11, 2021
View reviewed changes
@neersighted neersighted self-assigned this Nov 11, 2021
neersighted
neersighted approved these changes Nov 11, 2021
View reviewed changes
Copy link
Member

@neersighted neersighted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased onto current master -- I don't see any reason why we can't unclamp this. LGTM!

@neersighted neersighted merged commit 6e53b90 into python-poetry:master Nov 11, 2021
@NeilGirdhar NeilGirdhar deleted the patch-1 branch November 11, 2021 15:14
neersighted added a commit that referenced this pull request Nov 13, 2021
@neersighted
Revert "Update packaging requirement to support >= 20.4 (e.g. 21.0) (#…
f55132a 
…4362)"

This reverts commit 6e53b90.
@neersighted neersighted mentioned this pull request Nov 13, 2021
Merged
abn pushed a commit that referenced this pull request Nov 13, 2021
@neersighted @abn
Revert "Update packaging requirement to support >= 20.4 (e.g. 21.0) (#…
6c83817 
…4362)"

This reverts commit 6e53b90.
@neersighted neersighted mentioned this pull request Nov 13, 2021
Merged
1nF0rmed pushed a commit to 1nF0rmed/poetry that referenced this pull request Nov 15, 2021
@NeilGirdhar @1nF0rmed
Update packaging requirement to support >= 20.4 (e.g. 21.0) (python-p…
b0081bf 
…oetry#4362)
1nF0rmed pushed a commit to 1nF0rmed/poetry that referenced this pull request Nov 15, 2021
@neersighted @1nF0rmed
Revert "Update packaging requirement to support >= 20.4 (e.g. 21.0) (p…
78db4c1 
…ython-poetry#4362)"

This reverts commit 6e53b90.
edvardm pushed a commit to edvardm/poetry that referenced this pull request Nov 24, 2021
@NeilGirdhar @edvardm
Update packaging requirement to support >= 20.4 (e.g. 21.0) (python-p…
bc429ce 
…oetry#4362)
edvardm pushed a commit to edvardm/poetry that referenced this pull request Nov 24, 2021
@neersighted @edvardm
Revert "Update packaging requirement to support >= 20.4 (e.g. 21.0) (p…
5962abf 
…ython-poetry#4362)"

This reverts commit 6e53b90.
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@neersighted neersighted neersighted approved these changes

@hugovk hugovk hugovk left review comments

Assignees

@neersighted neersighted

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Packaging 21.0
4 participants
@NeilGirdhar @kkirsche @hugovk @neersighted