Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "Writing lock file" placement #114

Merged

Conversation

wagnerluis1982
Copy link
Contributor

@wagnerluis1982 wagnerluis1982 commented Apr 7, 2023

After python-poetry/poetry#7498, the output "Writing lock file" is now at the end of poetry add command.

This PR updates the output displayed in the front page https://python-poetry.org/

Screenshot (with the change)

image

@wagnerluis1982
Copy link
Contributor Author

I just realized that this PR must be applied only after next release.

So, I'm putting as a draft until it happens.

@wagnerluis1982 wagnerluis1982 marked this pull request as draft April 7, 2023 19:05
@wagnerluis1982 wagnerluis1982 marked this pull request as ready for review May 22, 2023 22:00
@wagnerluis1982 wagnerluis1982 force-pushed the update-writing-lock-file-output branch from b9e4e0f to 1ab3451 Compare May 22, 2023 22:00
@wagnerluis1982
Copy link
Contributor Author

wagnerluis1982 commented May 22, 2023

Since 1.5 was released, I guess this change to the front page should can be done.

@radoering radoering added the safe label May 23, 2023
@github-actions
Copy link

Deploy preview for website ready!

✅ Preview
https://website-mpmxc02s5-python-poetry.vercel.app

Built with commit 1ab3451.
This pull request is being automatically deployed with vercel-action

@radoering radoering merged commit cdf79a9 into python-poetry:main May 23, 2023
@wagnerluis1982 wagnerluis1982 deleted the update-writing-lock-file-output branch August 20, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants