fix(cmd-version): fix tag format on default version when force bump for initial release #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codejedi365
force-pushed
the
fix/tag-format-on-default-version-forced-bump
branch
2 times, most recently
from
035f145 to
fc67d2a
Compare
…or initial release Resolves: python-semantic-release#1137
codejedi365
force-pushed
the
fix/tag-format-on-default-version-forced-bump
branch
from
fc67d2a to
b7ab2bd
Compare
🎉 This PR has been published as part of Version 9.16.0 🎉You can find more information about this release on the GitHub Releases page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Rationale
Ended up the tag format was not applied to the default version value of
0.0.0when calculating a forced version bump. Now we use the translator to properly use the consumers tag format to translate the raw version into a tag, then parse back out the version to make a Version object. In this manner, now the version object has the tag format passed along from the translator upon initialization.How did you test?
I added an additional repository that was completely unreleased and had a tag format applied. This mirror the issue the user had in the reported issue. Then used that repository with the end-to-end tests related to force bumping a version.