Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP621: Migrate setup.py config into pyproject.toml #421

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,7 @@ repos:
args: [--autofix]
- id: pretty-format-yaml
args: [--autofix, --indent, '2']
- repo: https://github.com/abravalheri/validate-pyproject
rev: v0.12.1
hooks:
- id: validate-pyproject
49 changes: 49 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,3 +1,38 @@
[build-system]
build-backend = "setuptools.build_meta"
requires = ["setuptools>=61.2"]

[project]
authors = [{name = "Matias Aguirre", email = "[email protected]"}]
classifiers = [
"Development Status :: 5 - Production/Stable",
"Environment :: Web Environment",
"Intended Audience :: Developers",
"License :: OSI Approved :: BSD License",
"Programming Language :: Python",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Topic :: Internet"
]
dependencies = ["social-auth-core >= 4.1.0"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the requirements.txt? If you think it's too big change to do in this PR, please create another PR on top of this so that we can see a full scope of changes this will bring. Thanks.

Copy link
Contributor

@atodorov atodorov Mar 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO first remove dependencies from setup.py as a separate PR and then come back to this.

Update: this is already inside the removed requirements.txt.

description = "Python Social Authentication, Django integration."
dynamic = ["version"]
keywords = ["django", "social", "auth"]
license = {text = "BSD"}
name = "social-auth-app-django"
requires-python = ">=3.7"

[project.readme]
content-type = "text/markdown"
file = "README.md"

[project.urls]
Homepage = "https://github.com/python-social-auth/social-app-django"

[tool.ruff]
# Ignore some well known paths
exclude = [
Expand All @@ -19,3 +54,17 @@ target-version = "py37"

[tool.ruff.mccabe]
max-complexity = 10

[tool.setuptools]
include-package-data = false
license-files = ["LICENSE"]
packages = [
"social_django",
"social_django.migrations",
"social_django.management",
"social_django.management.commands"
]
zip-safe = false

[tool.setuptools.dynamic]
version = {attr = "social_django.__version__"}
5 changes: 2 additions & 3 deletions requirements-dev.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
pre-commit==3.1.1; python_version >= '3.8'
pre-commit==2.21.0; python_version < '3.8'
codecov==2.1.12
pre-commit==2.21.0; python_version < '3.8'
pre-commit==3.1.1; python_version >= '3.8'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already updated in #434 so I think you can drop this change.

tox==4.4.7
-r requirements.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove requirements.txt ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps read the commit message.

1 change: 0 additions & 1 deletion requirements.txt

This file was deleted.

60 changes: 0 additions & 60 deletions setup.py

This file was deleted.