Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lxml & xmlsec libxml2 library version mismatch #957

Closed
nijel opened this issue Jan 6, 2025 · 0 comments · Fixed by #986 or #1025
Closed

lxml & xmlsec libxml2 library version mismatch #957

nijel opened this issue Jan 6, 2025 · 0 comments · Fixed by #986 or #1025

Comments

@nijel
Copy link
Member

nijel commented Jan 6, 2025

Expected behaviour

#956 introduced Python 3.13 to CI and it should work.

Actual behaviour

It does not because xmlsec wheels for 3.13 are not available and the locally built module is incompatible with the lxml wheel.

What are the steps to reproduce this issue?

See the CI outcome: https://github.com/python-social-auth/social-core/actions/runs/12633678860/job/35199792957?pr=956

Any logs, error output, etc?

ERROR social_core/tests/backends/test_saml.py - xmlsec.InternalError: (-1, 'lxml & xmlsec libxml2 library version mismatch')

Any other comments?

This is the really annoying part of using xmlsec. It has to be built with the exactly same version of libxml as the lxml module. The lxml module embeds one, so if you build xmlsec locally and use lxml wheel, you end up with mixed up versions.

This affects our SAML users as well, it makes it more tricky to use the library.

Possible approach could be to bring back workaround removed in #906 (it has to be extended to ensure xmlsec wheels are also not used because meanwhile these are available as well).

@nijel nijel mentioned this issue Jan 6, 2025
11 tasks
@nijel nijel linked a pull request Jan 10, 2025 that will close this issue
11 tasks
nijel added a commit to nijel/social-core that referenced this issue Feb 17, 2025
This makes sure these are compatible regardless what lxml and xmlsec1
upstream does.

Fixes python-social-auth#957
nijel added a commit to nijel/social-core that referenced this issue Feb 17, 2025
This makes sure these are compatible regardless what lxml and xmlsec1
upstream does.

Fixes python-social-auth#957
nijel added a commit to nijel/social-core that referenced this issue Feb 17, 2025
This makes sure these are compatible regardless what lxml and xmlsec1
upstream does.

Fixes python-social-auth#957
nijel added a commit that referenced this issue Feb 17, 2025
This makes sure these are compatible regardless what lxml and xmlsec1
upstream does.

Fixes #957
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant