Add 106, don't fancy import trio #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
reviewed
Jul 28, 2022
|
While on it I resolved the above |
|
OK, apparently pushing commits marks the PR as closed rather than merged 😕 It's merged to me though! |
|
Yeah that's some funky UI. It's marked as Closed, but it also says It looks like TRIO106 is missing from the readme though |
|
It could be worth adding a test that checks that each error message is mentioned in all four of the readme, changelog, plugin file and test file. |
|
Sounds good, go for it! |
|
Opened an issue 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh, I'll just let you add this one to the changelog&readme, and increment version, with there being three simultaneous open pull requests.