Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6: async checkpoints #16

Merged
merged 9 commits into from
Jul 31, 2022
Merged

6: async checkpoints #16

merged 9 commits into from
Jul 31, 2022

Conversation

jakkdl
Copy link
Member

@jakkdl jakkdl commented Jul 30, 2022

I had an eye on this one when working on trio103/104, which is why that one is a bit overkill for a relatively simple check - but made it a breeze to implement this one since it's got a large overlap.

Added messages temporarily as 300 & 301 to avoid numbering conflicts, will change that to 1XX once ready to merge. (Unfortunately needs changing in a bunch of places in the code)

@jakkdl jakkdl marked this pull request as draft July 30, 2022 12:43
@jakkdl jakkdl changed the title 6 async checkpoints 6: async checkpoints Jul 30, 2022
Copy link
Member

@Zac-HD Zac-HD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

tests/trio300_301.py Outdated Show resolved Hide resolved
tests/trio300_301.py Outdated Show resolved Hide resolved
@Zac-HD Zac-HD mentioned this pull request Jul 30, 2022
12 tasks
@jakkdl jakkdl force-pushed the 6_async_checkpoints branch from 065404d to 6ad9d96 Compare July 30, 2022 19:23
@jakkdl jakkdl marked this pull request as ready for review July 30, 2022 19:23
@jakkdl
Copy link
Member Author

jakkdl commented Jul 30, 2022

rebased onto master, fixed your comments, fixed TRIO103 errors in the 107_108 file, and incremented version~ ✨

Copy link
Member

@Zac-HD Zac-HD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ 🎉 🚢

@Zac-HD Zac-HD merged commit 58d9194 into python-trio:main Jul 31, 2022
@jakkdl jakkdl deleted the 6_async_checkpoints branch August 23, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants