Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSocketConnection now inherits AsyncResource #24

Merged
merged 3 commits into from
Sep 18, 2018
Merged

WebSocketConnection now inherits AsyncResource #24

merged 3 commits into from
Sep 18, 2018

Conversation

mehaase
Copy link
Contributor

@mehaase mehaase commented Sep 14, 2018

Would appreciate your feedback, @belm0 and @njsmith, if you have the time.

@mehaase
Introduce a few very basic tests.
cb9e4e9 
This is preparation for introducing AsyncResource as a base class.
@mehaase
WebSocketConnection now inherits from AsyncResource
90c3522
@mehaase mehaase requested a review from belm0 September 14, 2018 13:34
belm0
belm0 reviewed Sep 14, 2018
View reviewed changes
README.md Show resolved Hide resolved
examples/client.py Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
tests/test_connection.py Outdated Show resolved Hide resolved
tests/test_connection.py Outdated Show resolved Hide resolved
trio_websocket/__init__.py Outdated Show resolved Hide resolved
This was referenced Sep 17, 2018
Closed
Closed
@mehaase mehaase merged commit 51b6cfe into master Sep 18, 2018
@mehaase mehaase mentioned this pull request Sep 18, 2018
Closed
@mehaase mehaase deleted the async_resource branch September 28, 2018 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belm0 belm0 belm0 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mehaase @belm0