-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to using standalone Outcome library. #503
Merged
Merged
Changes from 2 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
e27b50a
Switch to using standalone Outcome library.
Fuyukai d645b06
Rip out Result code from the rest of the core.
Fuyukai c7f4c67
Remove certain references in old changelog entries.
Fuyukai 04452e5
Add outcome to intersphinx mapping
Fuyukai 005b633
Move deprecated attributes to the right place.
Fuyukai 6587bbf
Fix RTD link
Fuyukai cad04ae
Solve the curse of the mutable default
Fuyukai 89f3150
Fix reschedule docstring
Fuyukai d49962c
Remove broken test code (this was basically testing a different libra…
Fuyukai 7bc2a18
Fix some usages of _core.Value/Error and default Value values.
Fuyukai 768fdcf
Missing newline
Fuyukai 58a431a
Simplify socket_ready helper a bit
njsmith 83fec3f
Remove vestigial enable_attribute_deprecations call
njsmith ed0510a
Fix __deprecated_attributes__ usage
njsmith 0cbed90
Re-YAPFify
Fuyukai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh. Could you please keep the newline?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, missed that. Surprised yapf didn't catch it.