Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.6, drop unsupported 2.6, 3.2, 3.3 #365

Closed
wants to merge 1 commit into from

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Oct 1, 2017

Reasons for dropping old ones

2.6

3.2

  • pip 8 no longer supports Python 3.2 (link)
  • Coverage 4 no longer supports Python 3.2 (link)
  • Requests no longer supports Python 3.2

3.3

@coveralls
Copy link

coveralls commented Oct 1, 2017

Coverage Status

Coverage remained the same at 29.931% when pulling 988a240 on hugovk:update-versions into 6c465f7 on sixohsix:master.

@RouxRC
Copy link
Member

RouxRC commented Oct 2, 2017

For once, I'm not completely in favor of this: dropping 2.6 or 3.2 can potentially break existing deployed software on machines still relying on those (full disclosure, I run bots using python-twitter on old debian servers under python2.6 ;( )
Although I hear it is now officially deprecated, so I can understand endorsing it now makes sense, and bad server maintainers like myself should then probably just freeze their pip requirements on packages depending on this.
So my apologies for this time @hugovk, I'll respectfully let @sixohsix decide on this one ;)

@hugovk
Copy link
Member Author

hugovk commented Oct 17, 2017

Here's how many pip installs Python Twitter Tools has had from PyPI over the past month:

$ pypinfo --pip --percent twitter pyversion
python_version percent download_count
-------------- ------- --------------
2.7              79.2%         17,371
3.6              10.0%          2,205
3.5               8.9%          1,945
3.4               1.6%            357
3.3               0.1%             29
3.7               0.1%             22
2.6               0.0%              9
3.2               0.0%              5

@sixohsix
Copy link
Collaborator

I'm with RouxRC on this. The arguments are not convincing to me.

Though users running 3.5 or 2.6 will probably experience pain trying to work with updated versions of pip, coverage, requests, etc. there is no reason to believe that they will encounter any problems with this twitter package. The code hasn't introduced any breaking changes so far as I know.

I would merge this change when either of two things happen:

  • we introduce code changes that we know will break with 2.6 or 3.5.
  • users encounter problems running this package with 2.6 or 3.5 (that is: when this happens, rather than put in the effort to fix this package, we might opt to deprecate those versions instead.)

In short, I do not want to merge this at this time.

@sixohsix sixohsix closed this Oct 19, 2017
@hugovk hugovk deleted the update-versions branch October 12, 2019 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants