fix cycles in when traversing graph #520
Conversation
| if match_dep_types and edge.req_type not in match_dep_types: | ||
| continue | ||
| visited.add(edge.destination_node.key) |
There was a problem hiding this comment.
We should add the start nodes, too, right?
There was a problem hiding this comment.
they will get added when they are being process in the loop
There was a problem hiding this comment.
I don't think the start nodes from self.nodes[ROOT].children on line 243 will be added unless they also appear as a destination node of something else, right?
One way to address it would be to add start_node to the visited set as the first thing this function does. That way every node that is traversed is added. I think if you make that change, you don't need line 291, because the set will be updated during the recursion on line 293.
There was a problem hiding this comment.
Oh I think the confusion is the name of the variable start_nodes. It should be start_edges because children is an array of edges. I have added a test case that adds a duplicate toplevel entry (start node) and the test passes
shubhbapna
force-pushed
the
fix-cycles-in-graph
branch
from
ad18b77 to
05f48d7
Compare
shubhbapna
force-pushed
the
fix-cycles-in-graph
branch
from
05f48d7 to
6aa4f20
Compare
due to cycles graph traversal would cause maximum recursive depth reached error Signed-off-by: Shubh Bapna <[email protected]>
shubhbapna
force-pushed
the
fix-cycles-in-graph
branch
from
6aa4f20 to
15bc9e5
Compare
| if match_dep_types and edge.req_type not in match_dep_types: | ||
| continue | ||
| visited.add(edge.destination_node.key) |
fixes #519
due to cycles graph traversal would cause maximum recursive depth reached error