use local cache when bootstrapping #528
Merged
+6
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We added an option to check an external cache for wheels matching the version and build tag computed during bootstrapping, but the implementation of that feature lost the ability to skip rebuilding something that was already on the local disk. This change restores that behavior, which is especially useful for developers bootstrapping locally.
Use TextIOBase instead of TextIOWrapper
tiran
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added an option to check an external cache for wheels matching the
version and build tag computed during bootstrapping, but the
implementation of that feature lost the ability to skip rebuilding
something that was already on the local disk. This change restores that
behavior, which is especially useful for developers bootstrapping
locally.