Implement simple asyncio wrapper API with basic tests #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 22, 2021
houndci-bot
reviewed
Jun 22, 2021
houndci-bot
reviewed
Jun 22, 2021
houndci-bot
reviewed
Jun 22, 2021
| sleep_time = cur_delay * get_jitter() | ||
| if ( | ||
| stop_time is not None | ||
| and time.perf_counter() + sleep_time >= stop_time |
…ze asyncio support
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes (or attempts to fix) #185 and #499.
Asyncio interoperability is required for what I'm working on, so I've came up with a simple solution. There is no change to the already existing client or handlers. The asyncio client expands on the base threaded implementation. The completely separate implementation ensures no breaking changes.
Python version support
Further work
The KazooRetry implementation cannot be used with the new asyncio API. I'm on the fence about re-implementing it as using a general solution would likely be fine. If I used https://github.com/kaelzhang/python-aioretry for example, it would impose new dependencies though.
More tests would be nice definitely. However the wrapper API is so simple, that it may actually be unnecessary.
I'm going to use a build of this fork. Depending on my experiences I'll likely push updates here as necessary. However, I'm not sure if I'll have time to make this a complete PR with coverage and extended python version support.