Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax click dependency. #302

Merged
merged 2 commits into from
Jan 13, 2019
Merged

Relax click dependency. #302

merged 2 commits into from
Jan 13, 2019

Conversation

asvetlov
Copy link
Contributor

Allow to install cherry_picker with the modern click version

@asvetlov
Relax click dependency.
33b1de7 
Allow to install cherry_picker with the modern click version
@asvetlov asvetlov requested a review from Mariatta as a code owner January 13, 2019 13:48
willingc
willingc approved these changes Jan 13, 2019
View reviewed changes
Copy link

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @asvetlov.

@Mariatta Mariatta merged commit bff4148 into master Jan 13, 2019
@Mariatta Mariatta deleted the relax-click-dependency branch January 13, 2019 19:59
@Mariatta
Copy link
Member

Thanks! Do you need a release cut?

@asvetlov
Copy link
Contributor Author

It would be nice!

@Mariatta
Copy link
Member

Can you increase/update the version info, and the changelog?
Similar to https://github.com/python/core-workflow/pull/282/files

After that, create a GitHub tag of the release branch, and it will be automatically released to PyPI.

There's a brief write-up here: https://github.com/python/core-workflow/tree/master/cherry_picker#publishing-to-pypi

@asvetlov
Copy link
Contributor Author

Will try

@Mariatta
Copy link
Member

v1.2.2 is now on PyPI

webknjaz
webknjaz reviewed Feb 9, 2019
View reviewed changes
cherry_picker/cherry_picker/cherry_picker.py
@@ -381,11 +381,11 @@ def check_repo(self):
help=("Path to config file, .cherry_picker.toml "
"from project root by default"),
default=None)
@click.argument('commit_sha1', 'The commit sha1 to be cherry-picked', nargs=1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the explanation? How is this related to the click dependency update?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, they changed api..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explicitly forbade meaningless argument actually. The help was never displayed IIRC

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nevermind. I've already figured out that it fails with this arg under newer Click: https://travis-ci.org/python/core-workflow/jobs/491106736#L270

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz left review comments

@Mariatta Mariatta Mariatta approved these changes

@willingc willingc willingc approved these changes

Assignees
No one assigned
Labels
cherry_picker.py CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@asvetlov @Mariatta @webknjaz @willingc @the-knights-who-say-ni