bpo-35177, Python-ast.h: Fix "Yield" compiler warning (GH-10664)

Partially revert commit 5f2df88: add "#undef Yield" to .c files after including Python-ast.h. Fix the warning: winbase.h(102): warning C4005: 'Yield': macro redefinition
python · Nov 22, 2018 · 3bb183d · 3bb183d
1 parent 2cf5d32
commit 3bb183d
Show file tree

Hide file tree

Showing 8 changed files with 8 additions and 2 deletions.
diff --git a/Include/Python-ast.h b/Include/Python-ast.h
diff --git a/Modules/parsermodule.c b/Modules/parsermodule.c
@@ -32,6 +32,7 @@
 
 #include "Python.h"                     /* general Python API             */
 #include "Python-ast.h"                 /* mod_ty */
+#undef Yield   /* undefine macro conflicting with <winbase.h> */
 #include "ast.h"
 #include "graminit.h"                   /* symbols defined in the grammar */
 #include "node.h"                       /* internal parser structure      */

diff --git a/Parser/asdl_c.py b/Parser/asdl_c.py
@@ -1247,7 +1247,7 @@ def main(srcfile, dump_module=False):
             f.write('\n')
             f.write('#include "asdl.h"\n')
             f.write('\n')
-            f.write('#undef Yield /* undefine macro conflicting with winbase.h */\n')
+            f.write('#undef Yield   /* undefine macro conflicting with <winbase.h> */\n')
             f.write('\n')
             c = ChainOfVisitors(TypeDefVisitor(f),
                                 StructVisitor(f),

diff --git a/Python/bltinmodule.c b/Python/bltinmodule.c
@@ -3,6 +3,7 @@
 #include "Python.h"
 #include <ctype.h>
 #include "ast.h"
+#undef Yield   /* undefine macro conflicting with <winbase.h> */
 #include "pycore_pystate.h"
 
 _Py_IDENTIFIER(__builtins__);

diff --git a/Python/import.c b/Python/import.c
@@ -3,6 +3,7 @@
 #include "Python.h"
 
 #include "Python-ast.h"
+#undef Yield   /* undefine macro conflicting with <winbase.h> */
 #include "pycore_pyhash.h"
 #include "pycore_pylifecycle.h"
 #include "pycore_pymem.h"

diff --git a/Python/pylifecycle.c b/Python/pylifecycle.c
@@ -3,6 +3,7 @@
 #include "Python.h"
 
 #include "Python-ast.h"
+#undef Yield   /* undefine macro conflicting with <winbase.h> */
 #include "pycore_context.h"
 #include "pycore_hamt.h"
 #include "pycore_pathconfig.h"

diff --git a/Python/pythonrun.c b/Python/pythonrun.c
@@ -11,6 +11,7 @@
 #include "Python.h"
 
 #include "Python-ast.h"
+#undef Yield   /* undefine macro conflicting with <winbase.h> */
 #include "pycore_pystate.h"
 #include "grammar.h"
 #include "node.h"

diff --git a/Python/symtable.c b/Python/symtable.c
@@ -1,6 +1,7 @@
 #include "Python.h"
 #include "pycore_pystate.h"
 #include "symtable.h"
+#undef Yield   /* undefine macro conflicting with <winbase.h> */
 #include "structmember.h"
 
 /* error strings used for warnings */