gh-95041: Fail syslog.syslog in case inner call to syslog.openlog fai…

…ls (GH-95264) (cherry picked from commit b1f648e) Co-authored-by: Noam Cohen <[email protected]>
python · Jul 27, 2022 · 9640c4c · 9640c4c
1 parent 202311c
commit 9640c4c
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/Modules/syslogmodule.c b/Modules/syslogmodule.c
@@ -191,8 +191,14 @@ syslog_syslog(PyObject * self, PyObject * args)
          */
         if ((openargs = PyTuple_New(0))) {
             PyObject *openlog_ret = syslog_openlog(self, openargs, NULL);
-            Py_XDECREF(openlog_ret);
             Py_DECREF(openargs);
+            if (openlog_ret == NULL) {
+                return NULL;
+            }
+            Py_DECREF(openlog_ret);
+        }
+        else {
+            return NULL;
         }
     }