Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade OpenSSL bundled with windows to 1.1.1s #100180

Closed
mattip opened this issue Dec 11, 2022 · 5 comments
Closed

Upgrade OpenSSL bundled with windows to 1.1.1s #100180

mattip opened this issue Dec 11, 2022 · 5 comments
Labels
release-blocker type-feature A feature request or enhancement type-security A security issue

Comments

@mattip
Copy link
Contributor

mattip commented Dec 11, 2022 •
edited by bedevere-bot
Loading

Enhancement

The version of OpenSSL used in get_externals.bat is 1.1.1q, where 1.1.1s has been released. This in turn pulls from https://github.com/python/cpython-bin-deps/tree/openssl-bin, which was last updated by @zooba to 1.1.1q

Pitch

It would be nice to get the latest updates. Looking at the changelog I don't see anything critial for windows, so maybe 1.1.1q is still OK, in which csae feel free to close the issue.

Previous discussion

Linked PRs
@mattip mattip added the type-feature A feature request or enhancement label Dec 11, 2022
@zooba
Copy link
Member

zooba commented Dec 12, 2022

Agreed that there's nothing critical in there, but since you've created the issue, let's keep this open so we remember to update before the next round of releases.

We just released every version last week, so I'll mark this as a blocker before the next release (apart from the next 3.12 alpha), as there's a pretty good chance we'll get 1.1.1t before then.

@zooba zooba added type-security A security issue release-blocker and removed type-feature A feature request or enhancement labels Dec 12, 2022
@zooba zooba added the type-feature A feature request or enhancement label Dec 12, 2022
@Yhg1s
Copy link
Member

Yhg1s commented Jan 9, 2023

Since 3.12.0a4 is scheduled for today, do you want to get this done before I cut the release, @zooba?

@zooba
Copy link
Member

zooba commented Jan 9, 2023

@Yhg1s I'll get on it now

@ned-deily
Copy link
Member

We should also update the macOS installer as well. I'll do that and test it before tomorrow's release.

@bedevere-bot bedevere-bot mentioned this issue Jan 9, 2023
Merged
zooba added a commit to zooba/cpython that referenced this issue Jan 9, 2023
@zooba
pythongh-100180: Update Windows installer to OpenSSL 1.1.1s
892e7c3
zooba added a commit that referenced this issue Jan 9, 2023
@zooba
gh-100180: Update Windows installer to OpenSSL 1.1.1s (GH-100901)
d7ab714
@bedevere-bot bedevere-bot mentioned this issue Jan 9, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jan 9, 2023
@zooba @miss-islington
pythongh-100180: Update Windows installer to OpenSSL 1.1.1s (pythonGH…
a8bc480 
…-100901)

(cherry picked from commit d7ab714)

Co-authored-by: Steve Dower <[email protected]>
@bedevere-bot bedevere-bot mentioned this issue Jan 9, 2023
Merged
zooba added a commit that referenced this issue Jan 10, 2023
@zooba
gh-100180: Update Windows installer to OpenSSL 1.1.1s (GH-100903)
40d87ff
@bedevere-bot bedevere-bot mentioned this issue Jan 10, 2023
Merged
miss-islington added a commit that referenced this issue Jan 10, 2023
@miss-islington @zooba
gh-100180: Update Windows installer to OpenSSL 1.1.1s (GH-100901)
13453a2 
(cherry picked from commit d7ab714)

Co-authored-by: Steve Dower <[email protected]>
ned-deily added a commit to ned-deily/cpython that referenced this issue Jan 10, 2023
@ned-deily
pythongh-100180: Update macOS installer to OpenSSL 1.1.1s
976daaf
ned-deily added a commit to ned-deily/cpython that referenced this issue Jan 10, 2023
@ned-deily
Merge branch 'main' into pythongh-100180-openssl-111s-macos
0ab887e
@bedevere-bot bedevere-bot mentioned this issue Jan 10, 2023
Merged
ned-deily added a commit that referenced this issue Jan 10, 2023
@ned-deily
gh-100180: Update macOS installer to OpenSSL 1.1.1s (GH-100908)
57a5259
@bedevere-bot bedevere-bot mentioned this issue Jan 10, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jan 10, 2023
@ned-deily @miss-islington
pythongh-100180: Update macOS installer to OpenSSL 1.1.1s (pythonGH-1…
9255788 
…00908)

(cherry picked from commit 57a5259)

Co-authored-by: Ned Deily <[email protected]>
@bedevere-bot bedevere-bot mentioned this issue Jan 10, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jan 10, 2023
@ned-deily @miss-islington
pythongh-100180: Update macOS installer to OpenSSL 1.1.1s (pythonGH-1…
700ef13 
…00908)

(cherry picked from commit 57a5259)

Co-authored-by: Ned Deily <[email protected]>
miss-islington added a commit that referenced this issue Jan 10, 2023
@miss-islington @ned-deily
gh-100180: Update macOS installer to OpenSSL 1.1.1s (GH-100908)
f6decc5 
(cherry picked from commit 57a5259)

Co-authored-by: Ned Deily <[email protected]>
miss-islington added a commit that referenced this issue Jan 10, 2023
@miss-islington @ned-deily
gh-100180: Update macOS installer to OpenSSL 1.1.1s (GH-100908)
ecb3be9 
(cherry picked from commit 57a5259)

Co-authored-by: Ned Deily <[email protected]>
CAM-Gerlach pushed a commit to CAM-Gerlach/cpython that referenced this issue Jan 14, 2023
@zooba @CAM-Gerlach
[3.11] pythongh-100180: Update Windows installer to OpenSSL 1.1.1s (p…
17df0c8 
…ythonGH-100901)

(cherry picked from commit d7ab714)

Co-authored-by: Steve Dower <[email protected]>
CAM-Gerlach pushed a commit to CAM-Gerlach/cpython that referenced this issue Jan 14, 2023
@zooba @CAM-Gerlach
[3.11] pythongh-100180: Update Windows installer to OpenSSL 1.1.1s (p…
527c7ea 
…ythonGH-100901)

(cherry picked from commit d7ab714)

Co-authored-by: Steve Dower <[email protected]>
ambv pushed a commit that referenced this issue Jan 20, 2023
@zooba
[3.9] gh-100180: Update Windows installer to OpenSSL 1.1.1s (GH-100903)…
fcfa505 
… (#100904)
zooba added a commit to zooba/cpython that referenced this issue Jan 23, 2023
@zooba
[3.8] pythongh-100180: Update Windows installer to OpenSSL 1.1.1s (py…
41e1c4f 
…thonGH-100903)
This was referenced Jan 23, 2023
Merged
Merged
zooba added a commit to zooba/cpython that referenced this issue Jan 23, 2023
@zooba
[3.7] pythongh-100180: Update Windows installer to OpenSSL 1.1.1s (py…
d06e8b0 
…thonGH-100903)
ambv pushed a commit that referenced this issue Jan 23, 2023
@zooba
[3.8] gh-100180: Update Windows installer to OpenSSL 1.1.1s (GH-100903)…
be3b5f7 
… (#101258)
ned-deily pushed a commit that referenced this issue Jan 25, 2023
@zooba
gh-100180: Update Windows installer to OpenSSL 1.1.1s (GH-100903) (GH…
ae3dea3 
…-101259)
@mattip
Copy link
Contributor Author

mattip commented Feb 1, 2023

Closing as complete. Please reopen if I am mistaken.

@mattip mattip closed this as completed Feb 1, 2023
carlosroman added a commit to DataDog/cpython that referenced this issue Jun 22, 2023
@carlosroman @ambv
@benjaminp @ned-deily @miss-islington @thunder-007 @gpshead @ucodery @hugovk @zooba @OTheDev @merwok @arhadthedev @corona10 @Blind4Basics @CAM-Gerlach @pradyunsg @encukou @samcarroll42 @ethanfurman @JelleZijlstra @gaogaotiantian @iritkatriel @stratakis @illia-v
Upgrade to 3.8.17 (#26)
e0a363f 
* Post 3.8.16

* [3.8] Update copyright years to 2023. (pythongh-100852)

* [3.8] Update copyright years to 2023. (pythongh-100848).
(cherry picked from commit 11f9932)

Co-authored-by: Benjamin Peterson <[email protected]>

* Update additional copyright years to 2023.

Co-authored-by: Ned Deily <[email protected]>

* [3.8] Update copyright year in README (pythonGH-100863) (pythonGH-100867)

(cherry picked from commit 30a6cc4)

Co-authored-by: Ned Deily <[email protected]>
Co-authored-by: HARSHA VARDHAN <[email protected]>

* [3.8] Correct CVE-2020-10735 documentation (pythonGH-100306) (python#100698)

(cherry picked from commit 1cf3d78)
(cherry picked from commit 88fe8d7)

Co-authored-by: Jeremy Paige <[email protected]>
Co-authored-by: Gregory P. Smith <[email protected]>

* [3.8] Bump Azure Pipelines to ubuntu-22.04 (pythonGH-101089) (python#101215)

(cherry picked from commit c22a55c)

Co-authored-by: Hugo van Kemenade <[email protected]>

* [3.8] pythongh-100180: Update Windows installer to OpenSSL 1.1.1s (pythonGH-100903) (python#101258)

* pythongh-101422: (docs) TarFile default errorlevel argument is 1, not 0 (pythonGH-101424)

(cherry picked from commit ea23271)

Co-authored-by: Owain Davies <[email protected]>

* [3.8] pythongh-95778: add doc missing in some places (pythonGH-100627) (python#101630)

(cherry picked from commit 4652182)

* [3.8] pythongh-101283: Improved fallback logic for subprocess with shell=True on Windows (pythonGH-101286) (python#101710)

Co-authored-by: Oleg Iarygin <[email protected]>
Co-authored-by: Steve Dower <[email protected]>

* [3.8] pythongh-101981: Fix Ubuntu SSL tests with OpenSSL (3.1.0-beta1) CI i… (python#102095)

[3.8] pythongh-101981: Fix Ubuntu SSL tests with OpenSSL (3.1.0-beta1) CI issue (pythongh-102079)

* [3.8] pythonGH-102306 Avoid GHA CI macOS test_posix failure by using the appropriate macOS SDK (pythonGH-102307)

[3.8] Avoid GHA CI macOS test_posix failure by using the appropriate macOS SDK.

* [3.8] pythongh-101726: Update the OpenSSL version to 1.1.1t (pythonGH-101727) (pythonGH-101752)

Fixes CVE-2023-0286 (High) and a couple of Medium security issues.
https://www.openssl.org/news/secadv/20230207.txt

Co-authored-by: Gregory P. Smith <[email protected]>
Co-authored-by: Ned Deily <[email protected]>

* [3.8] pythongh-102627: Replace address pointing toward malicious web page (pythonGH-102630) (pythonGH-102667)

(cherry picked from commit 61479d4)

Co-authored-by: Blind4Basics <[email protected]>
Co-authored-by: C.A.M. Gerlach <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>

* [3.8] pythongh-101997: Update bundled pip version to 23.0.1 (pythonGH-101998). (python#102244)

(cherry picked from commit 89d9ff0)

* [3.8] pythongh-102950: Implement PEP 706 – Filter for tarfile.extractall (pythonGH-102953) (python#104548)

Backport of c8c3956

* [3.8] pythongh-99889: Fix directory traversal security flaw in uu.decode() (pythonGH-104096) (python#104332)

(cherry picked from commit 0aeda29)

Co-authored-by: Sam Carroll <[email protected]>

* [3.8] pythongh-104049: do not expose on-disk location from SimpleHTTPRequestHandler (pythonGH-104067) (python#104121)

Do not expose the local server's on-disk location from `SimpleHTTPRequestHandler` when generating a directory index. (unnecessary information disclosure)

(cherry picked from commit c7c3a60)

Co-authored-by: Ethan Furman <[email protected]>
Co-authored-by: Gregory P. Smith <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>

* [3.8] pythongh-103935: Use `io.open_code()` when executing code in trace and profile modules (pythonGH-103947) (python#103954)

Co-authored-by: Tian Gao <[email protected]>

* [3.8] pythongh-68966: fix versionchanged in docs (pythonGH-105299)

* [3.8] Update GitHub CI workflow for macOS. (pythonGH-105302)

* [3.8] pythongh-105184: document that marshal functions can fail and need to be checked with PyErr_Occurred (pythonGH-105185) (python#105222)

(cherry picked from commit ee26ca1)

Co-authored-by: Irit Katriel <[email protected]>

* [3.8] pythongh-102153: Start stripping C0 control and space chars in `urlsplit` (pythonGH-102508) (pythonGH-104575) (pythonGH-104592) (python#104593) (python#104895)

`urllib.parse.urlsplit` has already been respecting the WHATWG spec a bit pythonGH-25595.

This adds more sanitizing to respect the "Remove any leading C0 control or space from input" [rule](https://url.spec.whatwg.org/GH-url-parsing:~:text=Remove%20any%20leading%20and%20trailing%20C0%20control%20or%20space%20from%20input.) in response to [CVE-2023-24329](https://nvd.nist.gov/vuln/detail/CVE-2023-24329).

I simplified the docs by eliding the state of the world explanatory
paragraph in this security release only backport.  (people will see
that in the mainline /3/ docs)

(cherry picked from commit d7f8a5f)
(cherry picked from commit 2f630e1)
(cherry picked from commit 610cc0a)
(cherry picked from commit f48a96a)

Co-authored-by: Miss Islington (bot) <[email protected]>
Co-authored-by: Illia Volochii <[email protected]>
Co-authored-by: Gregory P. Smith [Google] <[email protected]>

* [3.8] pythongh-103142: Upgrade binary builds and CI to OpenSSL 1.1.1u (pythonGH-105174) (pythonGH-105200) (pythonGH-105205) (python#105370)

Upgrade builds to OpenSSL 1.1.1u.

Also updates _ssl_data_111.h from OpenSSL 1.1.1u, _ssl_data_300.h from 3.0.9.

Manual edits to the _ssl_data_300.h file prevent it from removing any
existing definitions in case those exist in some peoples builds and were
important (avoiding regressions during backporting).

(cherry picked from commit ede89af)
(cherry picked from commit e15de14)

Co-authored-by: Gregory P. Smith <[email protected]>
Co-authored-by: Ned Deily <[email protected]>

* Python 3.8.17

* Post 3.8.17

* Updated CI to build 3.8.17

---------

Co-authored-by: Łukasz Langa <[email protected]>
Co-authored-by: Benjamin Peterson <[email protected]>
Co-authored-by: Ned Deily <[email protected]>
Co-authored-by: Miss Islington (bot) <[email protected]>
Co-authored-by: HARSHA VARDHAN <[email protected]>
Co-authored-by: Gregory P. Smith <[email protected]>
Co-authored-by: Jeremy Paige <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Steve Dower <[email protected]>
Co-authored-by: Owain Davies <[email protected]>
Co-authored-by: Éric <[email protected]>
Co-authored-by: Oleg Iarygin <[email protected]>
Co-authored-by: Steve Dower <[email protected]>
Co-authored-by: Dong-hee Na <[email protected]>
Co-authored-by: Blind4Basics <[email protected]>
Co-authored-by: C.A.M. Gerlach <[email protected]>
Co-authored-by: Pradyun Gedam <[email protected]>
Co-authored-by: Petr Viktorin <[email protected]>
Co-authored-by: Sam Carroll <[email protected]>
Co-authored-by: Ethan Furman <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Tian Gao <[email protected]>
Co-authored-by: Irit Katriel <[email protected]>
Co-authored-by: stratakis <[email protected]>
Co-authored-by: Illia Volochii <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
release-blocker type-feature A feature request or enhancement type-security A security issue
Projects
Release and Deferred blockers 🚫
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mattip @zooba @Yhg1s @ned-deily