Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please add the ssl_shutdown_timeout parameter for StreamWriter.start_tls() in asyncio #101317

Closed
beavailable opened this issue Jan 25, 2023 · 1 comment · Fixed by #101335
Closed

Please add the ssl_shutdown_timeout parameter for StreamWriter.start_tls() in asyncio #101317

beavailable opened this issue Jan 25, 2023 · 1 comment · Fixed by #101335
Assignees
@kumaraditya303
Labels
topic-asyncio

Comments

@beavailable
Copy link
Contributor

beavailable commented Jan 25, 2023 •
edited by bedevere-bot
Loading

Seems that StreamWriter.start_tls() method should have a ssl_shutdown_timeout parameter like other relevant methods.

Linked PRs
@github-project-automation github-project-automation bot moved this to Todo in asyncio Jan 25, 2023
@gvanrossum
Copy link
Member

Please submit a PR.

@beavailable beavailable mentioned this issue Jan 26, 2023
Merged
@kumaraditya303 kumaraditya303 linked a pull request Feb 1, 2023 that will close this issue
gh-101317: Add ssl_shutdown_timeout parameter for StreamWriter.start_tls() #101335
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in asyncio Feb 1, 2023
kumaraditya303 added a commit that referenced this issue Feb 1, 2023
@beavailable @kumaraditya303
gh-101317: Add ssl_shutdown_timeout parameter for `asyncio.StreamWr…
cc407b9 
…iter.start_tls` (#101335)

Co-authored-by: Kumar Aditya <[email protected]>
carljm added a commit to carljm/cpython that referenced this issue Feb 1, 2023
@carljm
Merge branch 'main' into inlinecomp2
8b76051 
* main:
  pythongh-98831: rewrite PUSH_EXC_INFO and conditional jumps in the instruction definition DSL (python#101481)
  pythongh-98831: Modernize the LOAD_ATTR family (python#101488)
  pythongh-101498 : Fix asyncio.Timeout example in docs (python#101499)
  pythongh-101454: fix documentation for END_ASYNC_FOR (python#101455)
  pythongh-101277: Isolate itertools, add group and _grouper types to module state (python#101302)
  pythongh-101317: Add `ssl_shutdown_timeout` parameter for `asyncio.StreamWriter.start_tls` (python#101335)
  datetime.rst: fix combine() signature (python#101490)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kumaraditya303 kumaraditya303

Labels
topic-asyncio
Projects
asyncio
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-101317: Add ssl_shutdown_timeout parameter for StreamWriter.start_tls()
4 participants
@gvanrossum @kumaraditya303 @AlexWaygood @beavailable