Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make: multibyte codecs lack dependencies #103527

Closed
erlend-aasland opened this issue Apr 13, 2023 · 1 comment · Fixed by #103528
Closed

Make: multibyte codecs lack dependencies #103527

erlend-aasland opened this issue Apr 13, 2023 · 1 comment · Fixed by #103528
Assignees
@erlend-aasland
Labels
build The build process and cross-build type-bug An unexpected behavior, bug, or error

Comments

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Apr 13, 2023 •
edited by bedevere-bot
Loading

There are no dependencies for the _codec_* and _multibytecodec modules, so if you're hacking away on a header file in Modules/cjkcodecs/ and execute make, you're not going to get a correct rebuild of those extension modules.

Linked PRs
@erlend-aasland erlend-aasland added type-bug An unexpected behavior, bug, or error build The build process and cross-build labels Apr 13, 2023
@erlend-aasland erlend-aasland self-assigned this Apr 13, 2023
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Apr 13, 2023
@erlend-aasland
pythongh-103527: Add make deps for _codecs_* and _multibytecodec
f5f39fe
@bedevere-bot bedevere-bot mentioned this issue Apr 13, 2023
Merged
@erlend-aasland erlend-aasland linked a pull request Apr 13, 2023 that will close this issue
gh-103527: Add make deps for _codecs_* and _multibytecodec #103528
Merged
erlend-aasland added a commit that referenced this issue Apr 14, 2023
@erlend-aasland
gh-103527: Add make deps for _codecs_* and _multibytecodec (#103528)
3d71b5e
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Apr 15, 2023
@erlend-aasland
pythongh-103527: Add multibytecodec.h as make dep for _codecs_*
3ea471f
@bedevere-bot bedevere-bot mentioned this issue Apr 15, 2023
Merged
@erlend-aasland
Copy link
Contributor Author

The _codecs_* extension modules all depend on multibytecodec.h. Reopening until fixed.

erlend-aasland added a commit that referenced this issue Apr 16, 2023
@erlend-aasland
gh-103527: Add multibytecodec.h as make dep for _codecs_* (#103567)
a210cac
carljm added a commit to carljm/cpython that referenced this issue Apr 17, 2023
@carljm
Merge branch 'main' into superopt
5136459 
* main:
  Remove `expert-*` from `project-updater` GH workflow (python#103579)
  pythongh-103583: Add codecs and maps to _codecs_* module state (python#103540)
  pythongh-48330: address review comments to PR-12271 (python#103209)
  pythongh-103527: Add multibytecodec.h as make dep for _codecs_* (python#103567)
  pythongh-103553: Improve `test_inspect`: add more assertions, remove unused (python#103554)
  pythonGH-103517: Improve tests for `pathlib.Path.walk()` (pythonGH-103518)
  pythongh-102114: Make dis print more concise tracebacks for syntax errors in str inputs (python#102115)
  pythonGH-78079: Fix UNC device path root normalization in pathlib (pythonGH-102003)
  pythongh-101517: Add regression test for a lineno bug in try/except* impacting pdb (python#103547)
  pythongh-103527: Add make deps for _codecs_* and _multibytecodec (python#103528)
  pythongh-103532: Fix reST syntax in NEWS entry (pythonGH-103544)
  pythongh-103532: Add NEWS entry (python#103542)
carljm added a commit to carljm/cpython that referenced this issue Apr 17, 2023
@carljm
Merge branch 'superopt' into superopt_spec
079c65a 
* superopt:
  update generated cases with new comment
  review comments
  Remove `expert-*` from `project-updater` GH workflow (python#103579)
  pythongh-103583: Add codecs and maps to _codecs_* module state (python#103540)
  pythongh-48330: address review comments to PR-12271 (python#103209)
  pythongh-103527: Add multibytecodec.h as make dep for _codecs_* (python#103567)
  pythongh-103553: Improve `test_inspect`: add more assertions, remove unused (python#103554)
  pythonGH-103517: Improve tests for `pathlib.Path.walk()` (pythonGH-103518)
  pythongh-102114: Make dis print more concise tracebacks for syntax errors in str inputs (python#102115)
  pythonGH-78079: Fix UNC device path root normalization in pathlib (pythonGH-102003)
  pythongh-101517: Add regression test for a lineno bug in try/except* impacting pdb (python#103547)
  pythongh-103527: Add make deps for _codecs_* and _multibytecodec (python#103528)
  pythongh-103532: Fix reST syntax in NEWS entry (pythonGH-103544)
  pythongh-103532: Add NEWS entry (python#103542)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erlend-aasland erlend-aasland

Labels
build The build process and cross-build type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-103527: Add make deps for _codecs_* and _multibytecodec erlend-aasland/cpython
1 participant
@erlend-aasland