Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildrelease.bat uses same build directory for AMD64 and ARM64 #123915

Closed
adang1345 opened this issue Sep 10, 2024 · 1 comment · Fixed by #123918
Closed

buildrelease.bat uses same build directory for AMD64 and ARM64 #123915

adang1345 opened this issue Sep 10, 2024 · 1 comment · Fixed by #123918
Labels
3.12 bugs and security fixes 3.13 bugs and security fixes 3.14 new features, bugs and security fixes build The build process and cross-build OS-windows type-bug An unexpected behavior, bug, or error

Comments

@adang1345
Copy link
Contributor

adang1345 commented Sep 10, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

When I build Python 3.11.10 installers using Tools\msi\buildrelease.bat -x64 -arm64, the AMD64 files under PCbuild\amd64\en-us are deleted when the ARM64 build starts.

This is due to a typo in the build directory for ARM64 in Tools\msi\buildrelease.bat, which has set BUILD=%Py_OutDir%amd64\. This build directory conflicts with that for AMD64 and should instead be set BUILD=%Py_OutDir%arm64\. I'll create a PR.

CPython versions tested on:

3.11

Operating systems tested on:

Windows

Linked PRs
@adang1345 adang1345 added the type-bug An unexpected behavior, bug, or error label Sep 10, 2024
@Eclips4 Eclips4 added OS-windows build The build process and cross-build labels Sep 10, 2024
@adang1345 adang1345 mentioned this issue Sep 10, 2024
Merged
@Eclips4 Eclips4 added 3.12 bugs and security fixes 3.13 bugs and security fixes 3.14 new features, bugs and security fixes labels Sep 10, 2024
zooba pushed a commit that referenced this issue Sep 10, 2024
@adang1345
gh-123915: Ensure that Windows AMD64 and ARM64 release builds use dif…
00ffdf2 
…ferent directories (GH-123918)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Sep 10, 2024
@adang1345 @miss-islington
pythongh-123915: Ensure that Windows AMD64 and ARM64 release builds u…
bccf62e 
…se different directories (pythonGH-123918)

(cherry picked from commit 00ffdf2)

Co-authored-by: adang1345 <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Sep 10, 2024
@adang1345 @miss-islington
pythongh-123915: Ensure that Windows AMD64 and ARM64 release builds u…
69d43b5 
…se different directories (pythonGH-123918)

(cherry picked from commit 00ffdf2)

Co-authored-by: adang1345 <[email protected]>
This was referenced Sep 10, 2024
Merged
Merged
@zooba
Copy link
Member

zooba commented Sep 10, 2024

Thanks!

zooba pushed a commit that referenced this issue Sep 10, 2024
@miss-islington @adang1345
gh-123915: Ensure that Windows AMD64 and ARM64 release builds use dif…
41608f1 
…ferent directories (GH-123918)

(cherry picked from commit 00ffdf2)

Co-authored-by: adang1345 <[email protected]>
Yhg1s pushed a commit that referenced this issue Sep 30, 2024
@miss-islington @adang1345
[3.13] gh-123915: Ensure that Windows AMD64 and ARM64 release builds …
3fd3b8a 
…use different directories (GH-123918) (#123921)

gh-123915: Ensure that Windows AMD64 and ARM64 release builds use different directories (GH-123918)
(cherry picked from commit 00ffdf2)

Co-authored-by: adang1345 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.12 bugs and security fixes 3.13 bugs and security fixes 3.14 new features, bugs and security fixes build The build process and cross-build OS-windows type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-123915: Ensure that AMD64 and ARM64 builds use different directories
3 participants
@zooba @adang1345 @Eclips4