-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The python PEG parser generator doesn't allow f-strings anymore in actions #125588
Comments
Signed-off-by: Pablo Galindo <[email protected]>
Signed-off-by: Pablo Galindo <[email protected]>
Signed-off-by: Pablo Galindo <[email protected]>
Signed-off-by: Pablo Galindo <[email protected]>
…25589) Signed-off-by: Pablo Galindo <[email protected]>
Just ran into this today when trying to test a clean build of main on my buildbot. My buildbot has a system python of 3.11, but with this change, it needs to be 3.12+ otherwise there's an exception on non-existent FSTRING_* attributes in the token module. The issue hasn't yet presented itself on any of the regular builder builds, I guess due to re-generation not usually being necessary, but presumably it will the next time the grammar is touched. It appears 3.10+ is the current minimum enforced by find_python.bat under Windows (and I believe configure under Linux). I can fix things by adding a default "None" parameter to the new getattr() calls (together with the existing "if not" checks) but am unsure if this would still produce the right final output, or if the minimum system python version just needs to be bumped. |
…ns (python#125589) Signed-off-by: Pablo Galindo <[email protected]>
I think that has been an oversight in #125589 I will fix it soon |
Signed-off-by: Pablo Galindo <[email protected]>
Signed-off-by: Pablo Galindo <[email protected]>
…ython#127969) Signed-off-by: Pablo Galindo <[email protected]>
…ns (python#125589) Signed-off-by: Pablo Galindo <[email protected]>
After the changes in 3.12 to the f-string formalisation, the PEG parser doesn't recognise the new tokens.
Linked PRs
The text was updated successfully, but these errors were encountered: