Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow copying of CodecInfo objects #66143

Closed
lehmannro mannequin opened this issue Jul 9, 2014 · 5 comments
Closed

Allow copying of CodecInfo objects #66143

lehmannro mannequin opened this issue Jul 9, 2014 · 5 comments
Labels
3.13 bugs and security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@lehmannro
Copy link
Mannequin

lehmannro mannequin commented Jul 9, 2014

BPO 21944
Nosy @malemburg, @berkerpeksag
Files
  • copy_codecinfo.patch: patch to current default
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2014-07-09.11:52:09.214>
    labels = ['type-feature', 'library', '3.11']
    title = 'Allow copying of CodecInfo objects'
    updated_at = <Date 2021-11-26.22:44:37.352>
    user = 'https://bugs.python.org/lehmannro'

    bugs.python.org fields:

    activity = <Date 2021-11-26.22:44:37.352>
    actor = 'iritkatriel'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2014-07-09.11:52:09.214>
    creator = 'lehmannro'
    dependencies = []
    files = ['35912']
    hgrepos = []
    issue_num = 21944
    keywords = ['patch']
    message_count = 2.0
    messages = ['222609', '236755']
    nosy_count = 3.0
    nosy_names = ['lemburg', 'lehmannro', 'berker.peksag']
    pr_nums = []
    priority = 'normal'
    resolution = None
    stage = None
    status = 'open'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue21944'
    versions = ['Python 3.11']

    Linked PRs

    @lehmannro
    Copy link
    Mannequin Author

    lehmannro mannequin commented Jul 9, 2014

    CodecInfo objects as retrieved from codecs.lookup currently throw an exception when trying to copy or pickle them.

    I have attached a patch with a fix and tests.

    @lehmannro lehmannro mannequin added type-bug An unexpected behavior, bug, or error stdlib Python modules in the Lib dir labels Jul 9, 2014
    @BreamoreBoy
    Copy link
    Mannequin

    BreamoreBoy mannequin commented Feb 27, 2015

    The change to codecs.py seems simple enough but would we usually use plain asserts in test code?

    @iritkatriel iritkatriel added 3.11 only security fixes type-feature A feature request or enhancement and removed type-bug An unexpected behavior, bug, or error labels Nov 26, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @furkanonder
    Copy link
    Contributor

    @lehmannro Are you gonna continue this task?

    @furkanonder
    Copy link
    Contributor

    The PR is ready for review.

    @serhiy-storchaka Can you review it?

    @serhiy-storchaka serhiy-storchaka added 3.13 bugs and security fixes and removed 3.11 only security fixes labels Sep 29, 2023
    @serhiy-storchaka
    Copy link
    Member

    Thanks @lehmannro for the initial patch and @furkanonder for bringing the issue to a successful end.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.13 bugs and security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    Status: Done
    Development

    No branches or pull requests

    3 participants