Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate syslog module to Argument Clinic #95011

Closed
noamcohen97 opened this issue Jul 19, 2022 · 2 comments · Fixed by #95012
Closed

Migrate syslog module to Argument Clinic #95011

noamcohen97 opened this issue Jul 19, 2022 · 2 comments · Fixed by #95012
Labels
topic-argument-clinic type-feature A feature request or enhancement

Comments

@noamcohen97
Copy link
Contributor

noamcohen97 commented Jul 19, 2022 •
edited
Loading

This will improve code readability and performance by delegating all of the argument parsing logic to Clinic.
@noamcohen97 noamcohen97 added the type-feature A feature request or enhancement label Jul 19, 2022
@noamcohen97 noamcohen97 mentioned this issue Jul 19, 2022
Merged
@erlend-aasland
Copy link
Contributor

Can you please provide a reason for why this change is needed? :)

@erlend-aasland
Copy link
Contributor

Thanks for explaining the change; that's good practise ;)

@serhiy-storchaka serhiy-storchaka mentioned this issue Jul 26, 2022
Merged
serhiy-storchaka pushed a commit that referenced this issue Oct 8, 2022
@noamcohen97
gh-95011: Migrate syslog module to Argument Clinic (GH-95012)
5405537
carljm added a commit to carljm/cpython that referenced this issue Oct 9, 2022
@carljm
Merge branch 'main' into typewatch
71d48c1 
* main:
  Minor edits to the Descriptor HowTo Guide (pythonGH-24901)
  Fix link to Lifecycle of a Pull Request in CONTRIBUTING (python#98102)
  pythonGH-94597: deprecate `SafeChildWatcher`, `FastChildWatcher` and `MultiLoopChildWatcher` child watchers  (python#98089)
  Auto-cancel old builds when new commit pushed to branch (python#98009)
  pythongh-95011: Migrate syslog module to Argument Clinic (pythonGH-95012)
carljm added a commit to carljm/cpython that referenced this issue Oct 9, 2022
@carljm
Merge branch 'main' into urllibnonet
132c32e 
* main: (5519 commits)
  Minor edits to the Descriptor HowTo Guide (pythonGH-24901)
  Fix link to Lifecycle of a Pull Request in CONTRIBUTING (python#98102)
  pythonGH-94597: deprecate `SafeChildWatcher`, `FastChildWatcher` and `MultiLoopChildWatcher` child watchers  (python#98089)
  Auto-cancel old builds when new commit pushed to branch (python#98009)
  pythongh-95011: Migrate syslog module to Argument Clinic (pythonGH-95012)
  pythongh-68686: Retire eptag ptag scripts (python#98064)
  pythongh-97922: Run the GC only on eval breaker (python#97920)
  GitHub Workflows security hardening (python#96492)
  Add `@ezio-melotti` as codeowner for `.github/`. (python#98079)
  pythongh-97913 Docs: Add walrus operator to the index (python#97921)
  [doc] Fix broken links to C extensions accelerating stdlib modules (python#96914)
  pythongh-97822: Fix http.server documentation reference to test() function (python#98027)
  pythongh-91052: Add PyDict_Unwatch for unwatching a dictionary (python#98055)
  pythonGH-98023: Change default child watcher to PidfdChildWatcher on supported systems (python#98024)
  pythonGH-94182: Run the PidfdChildWatcher on the running loop (python#94184)
  pythongh-92886: make test_ast pass with -O (assertions off) (pythonGH-98058)
  pythongh-92886: make test_coroutines pass with -O (assertions off) (pythonGH-98060)
  pythongh-57179: Add note on symlinks for os.walk (python#94799)
  pythongh-94808: Fix regex on exotic platforms (python#98036)
  pythongh-90085: Remove vestigial -t and -c timeit options (python#94941)
  ...
mpage pushed a commit to mpage/cpython that referenced this issue Oct 11, 2022
@noamcohen97 @mpage
pythongh-95011: Migrate syslog module to Argument Clinic (pythonGH-95012
1e204b1 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic-argument-clinic type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-95011: Migrate syslog module to Argument Clinic noamcohen97/cpython
2 participants
@noamcohen97 @erlend-aasland