-
-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQLITE_OK, SQLITE_DENY and SQLITE_IGNORE not explicitly documented #96096
Comments
Yep, we should document these, as they are part of the authorizer interface. Note that only FYI: Every SQLite result code is available as module level attributes. There are 152 of them. It may not make sense to cover each and everyone. Anyway, that is out of scope of this issue. |
Thanks @erlend-aasland . As the resident |
I won't have time the next few days, so if you feel the urge, please go ahead 🙂 |
Thanks, opened as #96134 |
…96134) Co-authored-by: Erlend E. Aasland <[email protected]> Co-authored-by: Ezio Melotti <[email protected]>
…nts (pythonGH-96134) Co-authored-by: Erlend E. Aasland <[email protected]> Co-authored-by: Ezio Melotti <[email protected]> (cherry picked from commit d6259c5) Co-authored-by: C.A.M. Gerlach <[email protected]>
…nts (pythonGH-96134) Co-authored-by: Erlend E. Aasland <[email protected]> Co-authored-by: Ezio Melotti <[email protected]> (cherry picked from commit d6259c5) Co-authored-by: C.A.M. Gerlach <[email protected]>
…H-96134) Co-authored-by: Erlend E. Aasland <[email protected]> Co-authored-by: Ezio Melotti <[email protected]> (cherry picked from commit d6259c5) Co-authored-by: C.A.M. Gerlach <[email protected]>
…H-96134) Co-authored-by: Erlend E. Aasland <[email protected]> Co-authored-by: Ezio Melotti <[email protected]> (cherry picked from commit d6259c5) Co-authored-by: C.A.M. Gerlach <[email protected]>
…nts (python#96134) Co-authored-by: Erlend E. Aasland <[email protected]> Co-authored-by: Ezio Melotti <[email protected]>
After #96095 is merged, the only remaining broken references/warnings in the
sqlite3
library documentation are for theSQLITE_OK
,SQLITE_DENY
andSQLITE_IGNORE
module-level constants that are referenced with:const:
underConnection.set_authorizer
, but not explicitly documented anywhere (as with the similar reference tosqlite.PrepareProtocol
fixed in #94321). Should we at least add brief mentions of them to module constants, e.g.Also, maybe
Connection.set_authorizer()
's docs should be updated to say something like "The callback should return :const:SQLITE_OK
. :const:SQLITE_DENY
. or :const:SQLITE_IGNORE
to control the resulting behavior for the column" rather than repeating ourselves.@erlend-aasland what do you think?
The text was updated successfully, but these errors were encountered: