Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlite3 docs: Connection methods and attribute order #96702

Closed
erlend-aasland opened this issue Sep 9, 2022 · 2 comments · Fixed by #96703
Closed

sqlite3 docs: Connection methods and attribute order #96702

erlend-aasland opened this issue Sep 9, 2022 · 2 comments · Fixed by #96703
Assignees
Labels
docs Documentation in the Doc dir topic-sqlite3

Comments

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Sep 9, 2022

Reading through the docs in their current form, I wonder if it was a mistake to put the connection attributes before the connection methods; for your everyday sqlite3 programming, I suspect you'll be using the connection methods way more often than you'll be using the connection attributes. I think we should consider putting the methods before the attributes.

Originally posted by @erlend-aasland in #96090 (comment)

UPDATE
Resolved with:

@erlend-aasland
Copy link
Contributor Author

cc. @CAM-Gerlach

@CAM-Gerlach
Copy link
Member

Yeah, agreed—I was thinking the same when I was a PR to the Cursor class to match Connection, as I got second thoughts and didn't go through with it.

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Sep 13, 2022
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Sep 13, 2022
…on docs (pythonGH-96703).

(cherry picked from commit 49cceeb)

Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland added a commit that referenced this issue Sep 13, 2022
GH-96703). (#96789)

(cherry picked from commit 49cceeb)

Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland added a commit that referenced this issue Sep 14, 2022
…6703) (#96788)

(cherry picked from commit 49cceeb)

Co-authored-by: Erlend E. Aasland <[email protected]>

Co-authored-by: Erlend E. Aasland <[email protected]>
pablogsal pushed a commit that referenced this issue Oct 22, 2022
…6703) (#96788)

(cherry picked from commit 49cceeb)

Co-authored-by: Erlend E. Aasland <[email protected]>

Co-authored-by: Erlend E. Aasland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir topic-sqlite3
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants