-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-101440: fix json snippet error in logging-cookbook.rst #101439
gh-101440: fix json snippet error in logging-cookbook.rst #101439
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was not a valid JSON, trailing commas are not allowed (except for json5
).
Thanks!
Thanks @peterjpxie for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
GH-101463 is a backport of this pull request to the 3.11 branch. |
…onGH-101439) (cherry picked from commit 20c11f2) Co-authored-by: Peter Jiping Xie <[email protected]>
GH-101464 is a backport of this pull request to the 3.10 branch. |
…onGH-101439) (cherry picked from commit 20c11f2) Co-authored-by: Peter Jiping Xie <[email protected]>
(cherry picked from commit 20c11f2) Co-authored-by: Peter Jiping Xie <[email protected]>
…101439) (GH-101463) (cherry picked from commit 20c11f2) Co-authored-by: Peter Jiping Xie <[email protected]> Automerge-Triggered-By: GH:hugovk
* main: pythongh-101440: fix json snippet error in logging-cookbook.rst (python#101439) pythongh-99276 - Updated Doc/faq/general.rst (python#101396) Add JOBS parameter to docs Makefile (python#101395) pythongh-98831: rewrite GET_LEN, GET_ITER, BEFORE_WITH and a few simple opcodes in the instruction definition DSL (python#101443) pythongh-77607: Improve accuracy of os.path.join docs (python#101406) Fixes typo in asyncio.TaskGroup context manager code example (python#101449) pythongh-98831: Clean up and add cache size static_assert to macro (python#101442) pythongh-99955: use SUCCESS/ERROR return values in optimizer and assembler. Use RETURN_IF_ERROR where appropriate. Fix a couple of bugs. (python#101412)
remove the extra comma (,)