gh-102204: Fix endianness issue in AIX #102206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can someone review this ? It's a small change which fixes the _hacl module build in AIX. |
|
This code comes from the upstream HACL* project, can you also file an issue or PR with them to get AIX-relevant code into https://github.com/hacl-star/hacl-star/blob/main/dist/karamel/include/krml/lowstar_endianness.h? |
This was referenced Apr 3, 2023
|
it looks like this was fixed upstream and we recently pulled in an updated hacl* when the sha3 code was merged. can you check main today and see if there is still any work to be done? |
It works now. Thanks for the support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix the problem mentioned in the issue #102204