Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-102341: Improve the test function for pow #102342

Merged
merged 7 commits into from
Mar 5, 2023
Merged

GH-102341: Improve the test function for pow #102342

merged 7 commits into from
Mar 5, 2023

Conversation

ppmfloss
Copy link
Contributor

@ppmfloss ppmfloss commented Feb 28, 2023 •
edited by bedevere-bot
Loading

Currently in the powtest function in Lib/test/test_pow.py file we are not testing the results of calling pow with negative exponents.
This PR will add appropriate assert statements to test the results of calling pow with negative exponents.

@bedevere-bot bedevere-bot mentioned this pull request Feb 28, 2023
Closed
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Feb 28, 2023
@terryjreedy terryjreedy added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Feb 28, 2023
@terryjreedy
Copy link
Member

Mark and Raymond, a one-line addition to test_pow that looks plausible but I am not sure.

Pipelines win32 failure is unrelated of type seen before.

@rhettinger rhettinger removed their request for review March 1, 2023 02:36
@mdickinson
Copy link
Member

Thanks for the ping, @terryjreedy. I'll take a look this weekend.

@mdickinson mdickinson self-assigned this Mar 1, 2023
mdickinson
mdickinson approved these changes Mar 4, 2023
View reviewed changes
Copy link
Member

@mdickinson mdickinson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we drop the for othertype in (int,): outer loop while we're here? (I'm guessing that it stems from Python 2 days, and was originally spelled for othertype in (int, long):.)

terryjreedy
terryjreedy requested changes Mar 4, 2023
View reviewed changes
Lib/test/test_pow.py Outdated Show resolved Hide resolved
Lib/test/test_pow.py Outdated Show resolved Hide resolved
Lib/test/test_pow.py Outdated Show resolved Hide resolved
@python python deleted a comment from bedevere-bot Mar 4, 2023
@terryjreedy
Copy link
Member

Please recheck after deletion, dedent, and condensation.

@ppmfloss
Copy link
Contributor Author

ppmfloss commented Mar 4, 2023

I have removed some indentation spaces and retested it locally successfully.

mdickinson
mdickinson approved these changes Mar 5, 2023
View reviewed changes
Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@terryjreedy terryjreedy merged commit 3222054 into python:main Mar 5, 2023
@miss-islington
Copy link
Contributor

Thanks @ppmfloss for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-102446 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Mar 5, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 5, 2023
@ppmfloss @terryjreedy @miss-islington
pythonGH-102341: Improve the test function for pow (pythonGH-102342)
88a27b9 
(cherry picked from commit 3222054)

Co-authored-by: Partha P. Mukherjee <[email protected]>
Co-authored-by: Terry Jan Reedy <[email protected]>
@bedevere-bot
Copy link

GH-102447 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 5, 2023
@ppmfloss @terryjreedy @miss-islington
pythonGH-102341: Improve the test function for pow (pythonGH-102342)
70560bd 
(cherry picked from commit 3222054)

Co-authored-by: Partha P. Mukherjee <[email protected]>
Co-authored-by: Terry Jan Reedy <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Mar 5, 2023
miss-islington added a commit that referenced this pull request Mar 5, 2023
@miss-islington @ppmfloss @terryjreedy
GH-102341: Improve the test function for pow (GH-102342)
9cec602 
(cherry picked from commit 3222054)

Co-authored-by: Partha P. Mukherjee <[email protected]>
Co-authored-by: Terry Jan Reedy <[email protected]>
miss-islington added a commit that referenced this pull request Mar 5, 2023
@miss-islington @ppmfloss @terryjreedy
GH-102341: Improve the test function for pow (GH-102342)
db8d10b 
(cherry picked from commit 3222054)

Co-authored-by: Partha P. Mukherjee <[email protected]>
Co-authored-by: Terry Jan Reedy <[email protected]>
hugovk pushed a commit to hugovk/cpython that referenced this pull request Mar 6, 2023
@ppmfloss @terryjreedy @hugovk
pythonGH-102341: Improve the test function for pow (python#102342)
7a07747 
Co-authored-by: Terry Jan Reedy <[email protected]>
carljm added a commit to carljm/cpython that referenced this pull request Mar 6, 2023
@carljm
Merge branch 'main' into nodeaddict
33dda2a 
* main: (21 commits)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives in sub interpreters module (python#102472)
  pythongh-95672: Fix versionadded indentation of get_pagesize in test.rst (pythongh-102455)
  pythongh-102416: Do not memoize incorrectly loop rules in the parser (python#102467)
  pythonGH-101362: Optimise PurePath(PurePath(...)) (pythonGH-101667)
  pythonGH-101362: Check pathlib.Path flavour compatibility at import time (pythonGH-101664)
  pythonGH-101362: Call join() only when >1 argument supplied to pathlib.PurePath() (python#101665)
  pythongh-102444: Fix minor bugs in `test_typing` highlighted by pyflakes (python#102445)
  pythonGH-102341: Improve the test function for pow (python#102342)
  Fix unused classes in a typing test (pythonGH-102437)
  pythongh-101979: argparse: fix a bug where parentheses in metavar argument of add_argument() were dropped (python#102318)
  pythongh-102356: Add thrashcan macros to filter object dealloc (python#102426)
  Move around example in to_bytes() to avoid confusion (python#101595)
  pythonGH-97546: fix flaky asyncio `test_wait_for_race_condition` test (python#102421)
  pythongh-96821: Add config option `--with-strict-overflow` (python#96823)
  pythongh-101992: update pstlib module documentation (python#102133)
  pythongh-63301: Set exit code when tabnanny CLI exits on error (python#7699)
  pythongh-101863: Fix wrong comments in EUC-KR codec (pythongh-102417)
  pythongh-102302 Micro-optimize `inspect.Parameter.__hash__` (python#102303)
  pythongh-102179: Fix `os.dup2` error reporting for negative fds (python#102180)
  pythongh-101892: Fix `SystemError` when a callable iterator call exhausts the iterator (python#101896)
  ...
carljm added a commit to carljm/cpython that referenced this pull request Mar 7, 2023
@carljm
Merge branch 'main' into inlinecomp2
ecb313c 
* main: (37 commits)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives in sub interpreters module (python#102472)
  pythongh-95672: Fix versionadded indentation of get_pagesize in test.rst (pythongh-102455)
  pythongh-102416: Do not memoize incorrectly loop rules in the parser (python#102467)
  pythonGH-101362: Optimise PurePath(PurePath(...)) (pythonGH-101667)
  pythonGH-101362: Check pathlib.Path flavour compatibility at import time (pythonGH-101664)
  pythonGH-101362: Call join() only when >1 argument supplied to pathlib.PurePath() (python#101665)
  pythongh-102444: Fix minor bugs in `test_typing` highlighted by pyflakes (python#102445)
  pythonGH-102341: Improve the test function for pow (python#102342)
  Fix unused classes in a typing test (pythonGH-102437)
  pythongh-101979: argparse: fix a bug where parentheses in metavar argument of add_argument() were dropped (python#102318)
  pythongh-102356: Add thrashcan macros to filter object dealloc (python#102426)
  Move around example in to_bytes() to avoid confusion (python#101595)
  pythonGH-97546: fix flaky asyncio `test_wait_for_race_condition` test (python#102421)
  pythongh-96821: Add config option `--with-strict-overflow` (python#96823)
  pythongh-101992: update pstlib module documentation (python#102133)
  pythongh-63301: Set exit code when tabnanny CLI exits on error (python#7699)
  pythongh-101863: Fix wrong comments in EUC-KR codec (pythongh-102417)
  pythongh-102302 Micro-optimize `inspect.Parameter.__hash__` (python#102303)
  pythongh-102179: Fix `os.dup2` error reporting for negative fds (python#102180)
  pythongh-101892: Fix `SystemError` when a callable iterator call exhausts the iterator (python#101896)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy terryjreedy requested changes

@mdickinson mdickinson mdickinson approved these changes

Assignees

@mdickinson mdickinson

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ppmfloss @terryjreedy @mdickinson @miss-islington @bedevere-bot @AlexWaygood