gh-103583: Isolate CJK modules, alternative 3 #103870
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
erlend-aasland
commented
Apr 26, 2023
•
erlend-aasland
commented
- Issue: Isolate _multibytecodec #103583
|
The approach I started on here is to pass the cjk module state to the cjk codec helpers, which means extensive changes in multibytecodec.c. IMO, this messes up the arg spec of the helpers too much, and I don't like the changes to _multibytecodec. I don't recommend this approach, but in theory it will work. |
|
Closing in favour of #103869 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.