Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-103629: Update typing.Unpack docs in compliance with PEP 692 #103894

Merged
merged 2 commits into from
Apr 26, 2023
Merged

gh-103629: Update typing.Unpack docs in compliance with PEP 692 #103894

merged 2 commits into from
Apr 26, 2023

Conversation

franekmagiera
Copy link
Contributor

@franekmagiera franekmagiera commented Apr 26, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels Apr 26, 2023
@bedevere-bot bedevere-bot mentioned this pull request Apr 26, 2023
Closed
@JelleZijlstra
Copy link
Member

Thanks! Could you add an entry to the 3.12 What's New and to the NEWS as well?

@franekmagiera
Copy link
Contributor Author

Thought about doing it in a separate PR but I can add it as a part of this one :) let me do that.

@AlexWaygood AlexWaygood added topic-typing 3.12 bugs and security fixes labels Apr 26, 2023
@AlexWaygood AlexWaygood merged commit dc3f975 into python:main Apr 26, 2023
@AlexWaygood
Copy link
Member

Thanks @franekmagiera!

rinarakaki
rinarakaki reviewed Oct 3, 2023
View reviewed changes
Doc/library/typing.rst

from typing import TypedDict, Unpack

class Movie(TypedDict):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 space tab would've been more consistent.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 spaces are the convention in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rinarakaki rinarakaki rinarakaki left review comments

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Assignees
No one assigned
Labels
3.12 bugs and security fixes docs Documentation in the Doc dir skip news topic-typing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@franekmagiera @JelleZijlstra @AlexWaygood @rinarakaki @bedevere-bot