-
-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-103921: Document PEP 695 #104642
Merged
Merged
gh-103921: Document PEP 695 #104642
Changes from 66 commits
Commits
Show all changes
69 commits
Select commit
Hold shift + click to select a range
786a436
First docs work
JelleZijlstra c1f266e
More words
JelleZijlstra 040c4fd
Merge remote-tracking branch 'upstream/main' into pep695docs
JelleZijlstra e3dfb27
ast changes, fix build
JelleZijlstra f5b1d86
the big PEP list
JelleZijlstra 5798631
dis
JelleZijlstra 0f76679
default roles
JelleZijlstra cb76021
TODOs in compound_stmts
JelleZijlstra 12c1249
minor
JelleZijlstra 94a4da2
Remove broken link
JelleZijlstra 815a021
update dis.dis docs
JelleZijlstra 17ac785
TypeAlias is deprecated
JelleZijlstra 1311399
Type aliases should now use the type statement
JelleZijlstra 123752c
syntax
JelleZijlstra 9d6e0c0
Merge branch 'main' into pep695docs
JelleZijlstra e955a45
Expand typing.rst
JelleZijlstra d7f2b55
Finish the type statement
JelleZijlstra 53c4916
What's New
JelleZijlstra edec8c3
Merge remote-tracking branch 'upstream/main' into pep695docs
JelleZijlstra bc1c1d2
typo
JelleZijlstra b1a843c
FQNs in ast.rst
JelleZijlstra e690aff
Merge remote-tracking branch 'upstream/main' into pep695docs
JelleZijlstra cc5b51c
Document TypeVar constructor signature, discuss variance
JelleZijlstra b0e1ce3
TypeVarTuple signature
JelleZijlstra 382ff2c
Fix sig
JelleZijlstra db94e4f
Document TypeVar attributes, fix indentation
JelleZijlstra 18b9d63
Fix TypeVarTuple indentation
JelleZijlstra b7ba811
Merge branch 'main' into pep695docs
AlexWaygood fd1d0a8
s/typeparams/type_params/
JelleZijlstra 62ba887
Apply suggestions from code review
JelleZijlstra 200eba1
Reword long dis sentence
JelleZijlstra adaf874
Manual changes from Alex review
JelleZijlstra 4481d6d
Merge remote-tracking branch 'upstream/main' into pep695docs
JelleZijlstra 365ae7b
Improve ast.TypeAlias text
JelleZijlstra 96e5d16
Document __type_params__
JelleZijlstra 0204d54
Add to datamodel.rst
JelleZijlstra f426d39
Wording change
JelleZijlstra 60d7783
Update Doc/library/typing.rst
JelleZijlstra 63d4d84
Apply suggestions from code review
JelleZijlstra fd6751a
fix indentation
JelleZijlstra 499dae1
Link to generic functions
JelleZijlstra b4172c9
Move up variance paragraph
JelleZijlstra e9bc4a8
Merge remote-tracking branch 'upstream/main' into pep695docs
JelleZijlstra 0d37675
Some Alex comments
JelleZijlstra c94ee7c
Fix alignment
JelleZijlstra 1630342
doctest maybe
JelleZijlstra aade45a
More Alex suggestions
JelleZijlstra 57b9992
Feedback from Carl
JelleZijlstra 7953d2c
Section on lazy eval
JelleZijlstra 9128c72
More cross-refs
JelleZijlstra 0511b6a
Can't have nice things
JelleZijlstra 4fd3f02
Respond to some feedback
JelleZijlstra fff0df4
Undo unnecessary typing.rst changes
JelleZijlstra ba2a103
Merge remote-tracking branch 'upstream/main' into pep695docs
JelleZijlstra 1c6807d
more words
JelleZijlstra 6386475
or
JelleZijlstra cd4206c
Update Doc/reference/compound_stmts.rst
JelleZijlstra e307177
Merge branch 'main' into pep695docs
AlexWaygood d7e1c6c
Apply suggestions from code review
JelleZijlstra f878970
More feedback from Alex
JelleZijlstra a4bd32a
fixes
JelleZijlstra ee8f952
Merge remote-tracking branch 'upstream/main' into pep695docs
JelleZijlstra 7a709d7
Rewrite and extend some docstrings
JelleZijlstra 0cfeb92
More comments
JelleZijlstra f978766
Docstring fixes
JelleZijlstra bba092d
tables
JelleZijlstra 57ddbef
more fixes
JelleZijlstra 67acd98
Merge remote-tracking branch 'upstream/main' into pep695docs
JelleZijlstra 988fc7c
Merge branch 'main' into pep695docs
AlexWaygood File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you may want to get somebody else (Brandt? Irit?) to look at the changes to this file; I'm far from an expert on |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just realised that
type_params
is in the wrong place here for the AST as it currently exists onmain
, wheretype_params
is at the end. But probably not worth fixing that until questions about the ABI are resolved in #104974.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, looks like you might have added
type_params
to the constructor forFunctionDef
andClassDef
, but notAsyncFunctionDef
!