Fix inaccuracies in "Assorted Topics" section of "Defining Extension Types" tutorial #104969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Guess it needs to be backported to 3.11 and 3.12. |
Eclips4
approved these changes
May 26, 2023
kumaraditya303
approved these changes
Jun 16, 2023
kumaraditya303
added
needs backport to 3.11
|
Thanks @chgnrdv for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
Sorry, @chgnrdv and @kumaraditya303, I could not cleanly backport this to |
|
GH-105850 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 16, 2023
…Types" tutorial (pythonGH-104969) (cherry picked from commit 0d09637) Co-authored-by: chgnrdv <[email protected]>
kumaraditya303
pushed a commit
that referenced
this pull request
Jun 16, 2023
…ension Types" tutorial (GH-104969) (#105850) Fix inaccuracies in "Assorted Topics" section of "Defining Extension Types" tutorial (GH-104969) (cherry picked from commit 0d09637) Co-authored-by: chgnrdv <[email protected]>
carljm
added a commit
to carljm/cpython
that referenced
this pull request
Jun 16, 2023
* main: pythongh-104799: PEP 695 backward compatibility for ast.unparse (python#105846) pythongh-105834: Add tests for calling `issubclass()` between two protocols (python#105835) CI: Remove docs build from Azure Pipelines (python#105823) pythongh-105844: Consistently use 'minor version' for X.Y versions (python#105851) Fix inaccuracies in "Assorted Topics" section of "Defining Extension Types" tutorial (python#104969) pythongh-105433: Add `pickle` tests for PEP695 (python#105443) bpo-44530: Document the change in MAKE_FUNCTION behavior (python#93189) pythonGH-103124: Multiline statement support for pdb (pythonGH-103125) pythonGH-105588: Add missing error checks to some obj2ast_* converters (pythonGH-105589)
gvanrossum
pushed a commit
to gvanrossum/cpython
that referenced
this pull request
Jun 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--104969.org.readthedocs.build/