GH-89812: Make symlink support configurable in pathlib tests. #106060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust the pathlib tests to add a new `PathTest.can_symlink` class attribute, which allows us to enable or disable symlink support in tests. A (near-)future commit will add an `AbstractPath` class; its tests will hard-code the value to `True` or `False` depending on a stub subclass's capabilities.
CAM-Gerlach
approved these changes
Jun 30, 2023
|
You might want to consider running against the buildbot fleet if you thing there's a chance this might trigger any behavior difference on different platforms, given the previous platform dependent code (special casing windows). |
Good idea! How do I do that? :) |
barneygale
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @barneygale for commit f9bdd3a 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the pathlib tests to add a new
PathTest.can_symlinkclass attribute, which allows us to enable or disable symlink support in tests. A (near-)future commit will add anAbstractPathclass; its tests will hard-code the value toTrueorFalsedepending on a stub subclass's capabilities.