-
-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-108223: Add --disable-gil to configure #108227
Conversation
The `--disable-gil` flags does not do anything yet other than define the Py_NOGIL macro. This is intended to support setting up additional buildbots.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I both check the following cases, and it works as expected!
- ./configure --disable-gil
- ./configure
@colesbury Are you ready to be merged or need more additional work? |
@corona10 thanks! it is ready to merge |
I dislike double negation, would it be possible to have a companion macro, like Py_HAVE_GIL? For example, Py_HAVE_GIL can be always defined, as 0 or 1. Or Py_HAVE_GIL would not be defined if Py_NOGIL is defined. In the long term, I would prefer that Python has no GIL by default, but so we would only have special code for the legacy build where Python has a GIL. Well, maybe that's a politic question :-) |
@vstinner, I generally agree with you about double negation, but I think in this case it's more convenient to define a
None of these reasons are tremendously important, but the choice of macro name doesn't seem tremendously important either. |
It's just a remark, I'm fine with Py_NOGIL. |
The
--disable-gil
flags does not do anything yet other than define the Py_NOGIL macro. This is intended to support setting up additional buildbots by @itamaro.