-
-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-108294: Add time.sleep audit event #108298
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the reasoning behind the feature. Tests work on my end.
@@ -414,6 +414,8 @@ Return the clk_id of a thread's CPU time clock."); | |||
static PyObject * | |||
time_sleep(PyObject *self, PyObject *timeout_obj) | |||
{ | |||
PySys_Audit("time.sleep", "O", timeout_obj); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why no error handling?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could tell you but it would sound like a lame excuse. (I picked up a low-priority task from May, and didn't realize how much work-in-progress it was...)
Thank you very much for spotting this! Fix incoming.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix in #108363.
|
📚 Documentation preview 📚: https://cpython-previews--108298.org.readthedocs.build/