Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-107603: Clinic: Pass specific attributes to print_block() #108581

Merged
merged 5 commits into from
Aug 28, 2023
Merged

GH-107603: Clinic: Pass specific attributes to print_block() #108581

merged 5 commits into from
Aug 28, 2023

Conversation

AA-Turner
Copy link
Member

@AA-Turner AA-Turner commented Aug 28, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Aug 28, 2023
Closed
@AA-Turner AA-Turner mentioned this pull request Aug 28, 2023
Merged
@AA-Turner
Copy link
Member Author

AA-Turner commented Aug 28, 2023 •
edited
Loading

mypy failure seems unrelated: (Edit: very related!)

@AA-Turner AA-Turner changed the title GH-107603: Clinic: Only pass includes to print_block() GH-107603: Clinic: Pass specific attributes to print_block() Aug 28, 2023
AlexWaygood
AlexWaygood reviewed Aug 28, 2023
View reviewed changes
Tools/clinic/clinic.py Outdated Show resolved Hide resolved
vstinner
vstinner approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AlexWaygood
AlexWaygood approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@AA-Turner
Copy link
Member Author

Thanks all for the (incredibly fast) reviews!

A

@AlexWaygood
Copy link
Member

AlexWaygood commented Aug 28, 2023 •
edited
Loading

Oh, looks like you'll need to slightly rework two unit tests in test_clinic.py to get CI passing

@AlexWaygood AlexWaygood enabled auto-merge (squash) August 28, 2023 20:39
@AlexWaygood AlexWaygood merged commit 0bd2ba5 into python:main Aug 28, 2023
@bedevere-bot

This comment was marked as abuse.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland left review comments

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood

@vstinner vstinner Awaiting requested review from vstinner

Assignees
No one assigned
Labels
awaiting core review skip news topic-argument-clinic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AA-Turner @AlexWaygood @bedevere-bot @vstinner @erlend-aasland